public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Luis Machado <luis.machado@arm.com>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH,v2] [AArch64] Fix testcase compilation failure
Date: Tue, 19 Jul 2022 14:37:17 +0100	[thread overview]
Message-ID: <61b3cba8-5c98-b265-57ef-478e146f9590@arm.com> (raw)
In-Reply-To: <20220711115835.23981-1-luis.machado@arm.com>

On 7/11/22 12:58, Luis Machado via Gdb-patches wrote:
> v2:
> 
> - Removed unused constants
> 
> --
> 
> Newer distros carry newer headers that contains MTE definitions.  Account
> for that fact in the MTE testcases and define constants conditionally to
> prevent compilation failures.
> ---
>   gdb/testsuite/gdb.arch/aarch64-mte.c | 15 ++++++++++-----
>   1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.arch/aarch64-mte.c b/gdb/testsuite/gdb.arch/aarch64-mte.c
> index bd7f1a6cf53..fc38d58fe5e 100644
> --- a/gdb/testsuite/gdb.arch/aarch64-mte.c
> +++ b/gdb/testsuite/gdb.arch/aarch64-mte.c
> @@ -30,22 +30,27 @@
>   #include <sys/prctl.h>
>   
>   /* From arch/arm64/include/uapi/asm/hwcap.h */
> +#ifndef HWCAP2_MTE
>   #define HWCAP2_MTE              (1 << 18)
> +#endif
>   
>   /* From arch/arm64/include/uapi/asm/mman.h */
> +#ifndef PROT_MTE
>   #define PROT_MTE  0x20
> +#endif
>   
> -/* From include/uapi/linux/prctl.h */
> +#ifndef PR_SET_TAGGED_ADDR_CTRL
>   #define PR_SET_TAGGED_ADDR_CTRL 55
> -#define PR_GET_TAGGED_ADDR_CTRL 56
>   #define PR_TAGGED_ADDR_ENABLE	(1UL << 0)
> +#endif
> +
> +/* From include/uapi/linux/prctl.h */
> +#ifndef PR_MTE_TCF_SHIFT
>   #define PR_MTE_TCF_SHIFT	1
> -#define PR_MTE_TCF_NONE		(0UL << PR_MTE_TCF_SHIFT)
>   #define PR_MTE_TCF_SYNC		(1UL << PR_MTE_TCF_SHIFT)
>   #define PR_MTE_TCF_ASYNC	(2UL << PR_MTE_TCF_SHIFT)
> -#define PR_MTE_TCF_MASK		(3UL << PR_MTE_TCF_SHIFT)
>   #define PR_MTE_TAG_SHIFT	3
> -#define PR_MTE_TAG_MASK		(0xffffUL << PR_MTE_TAG_SHIFT)
> +#endif
>   
>   void
>   access_memory (unsigned char *tagged_ptr, unsigned char *untagged_ptr)

Pushed now.

      reply	other threads:[~2022-07-19 13:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05 13:37 [PATCH] " Luis Machado
2022-07-05 14:49 ` Luis Machado
2022-07-11 11:58 ` [PATCH,v2] " Luis Machado
2022-07-19 13:37   ` Luis Machado [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61b3cba8-5c98-b265-57ef-478e146f9590@arm.com \
    --to=luis.machado@arm.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).