public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [committed][gdb/build] Fix gdb build with gcc 4.8.5
@ 2022-07-14  8:20 Tom de Vries
  0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2022-07-14  8:20 UTC (permalink / raw)
  To: gdb-patches

Hi,

When building gdb with gcc 4.8.5, we run into:
...
In file included from /usr/include/c++/4.8/future:43:0,
                 from gdbsupport/thread-pool.h:30,
                 from gdb/dwarf2/cooked-index.h:33,
                 from gdb/dwarf2/read.h:26,
                 from gdb/dwarf2/abbrev-cache.c:21:
/usr/include/c++/4.8/atomic: In instantiation of \
  ‘_Tp std::atomic<_Tp>::load(std::memory_order) const [with _Tp = \
  packed<dwarf_unit_type, 1ul>; std::memory_order = std::memory_order]’:
gdb/dwarf2/read.h:332:44:   required from here
/usr/include/c++/4.8/atomic:208:13: error: no matching function for call to \
  ‘packed<dwarf_unit_type, 1ul>::packed()’
         _Tp tmp;
             ^
...

Fix this by adding the default constructor for packed.

Tested on x86_64-linux, with gdb build with gcc 4.8.5.

Committed to trunk.

Thanks,
- Tom

[gdb/build] Fix gdb build with gcc 4.8.5

---
 gdbsupport/packed.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdbsupport/packed.h b/gdbsupport/packed.h
index cd331b5477d..3468cf44207 100644
--- a/gdbsupport/packed.h
+++ b/gdbsupport/packed.h
@@ -31,6 +31,8 @@ template<typename T, size_t Bytes = sizeof (T)>
 struct packed
 {
 public:
+  packed () noexcept = default;
+
   packed (T val)
   {
     m_val = val;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-07-14  8:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-14  8:20 [committed][gdb/build] Fix gdb build with gcc 4.8.5 Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).