From: Kevin Buettner <kevinb@redhat.com>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v5 00/15] basic linker namespace support
Date: Fri, 15 Jul 2022 17:04:53 -0700 [thread overview]
Message-ID: <20220715170453.1d5142e2@f35-zws-1> (raw)
In-Reply-To: <BN0PR11MB57579090C521D10C47379656DE8B9@BN0PR11MB5757.namprd11.prod.outlook.com>
Hi Markus,
On Fri, 15 Jul 2022 10:30:42 +0000
"Metzger, Markus T" <markus.t.metzger@intel.com> wrote:
> OK'ed by Kevin:
> > gdb, solib-svr4: remove locate_base()
> > gdb, gdbserver: support dlmopen()
> > gdbserver: move main_lm handling into caller
> > gdb, gdbserver: extend RSP to support namespaces
> > gdb, compile: unlink objfile stored in module
> > gdb, ada: update ada_lookup_simple_minsym
> > gdb, hppa: remove unused hppa_lookup_stub_minimal_symbol
> > gdb, symtab: inline find_quick_global_symbol_language
> > gdb, solib-svr4: support namespaces in DSO iteration
Yep.
> Reviewed by Kevin but asking for another reviewer:
> > gdb, ada: update ada_add_all_symbols
To be clear, I think this patch is okay, but someone who knows about
this area may want to take a look. If no one steps up, I think it
should go in.
>
> Not reviewed:
> > gdb, testsuite: extend gdb_test_multiple checks
I asked a question about this one. Basically, I'd like to understand
the circumstances which led you to making these changes.
> > gdb, python: use gdbarch_iterate_over_objfiles_in_search_order
I okayed this one.
> > gdb, ada: collect standard exceptions in all objfiles
That one looked reasonable to me, but an Ada expert may want to
take a look.
> > gdb, cp: update add_symbol_overload_list_qualified
I said, "LGTM", which is basically an "okay".
> > gdb: update gnu ifunc resolve
I okayed this one.
>
> Another question is what to do about those known issues:
>
> > - get_symbol_address() and get_msymbol_address() search objfiles for a
> > 'better' match. This was introduced by
> >
> > 4b610737f02 Handle copy relocations
> >
> > to handle copy relocations but it now causes a wrong address to be
> > read after symbol lookup actually found the correct symbol. This can
> > be seen, for example, with gdb.base/dlmopen.exp when compiled with
> > clang.
> >
> > - gnu ifuncs are only looked up in the initial namespace.
> >
> > - lookup_minimal_symbol() and lookup_minimal_symbol_text() directly
> > iterate over objfiles and are not aware of linker namespaces.
>
> Can they be accepted and addressed one-by-one? Or would they all need
> to be addressed before the series can be merged? I had to adjust two expected
> outputs but otherwise, tests pass on x86-64. We know that namespace
> support is incomplete, though.
>
> For get_symbol_address() and get_msymbol_address() I believe we need
> to remove the objfiles iteration and trust that the symbol is the right one
> and just return its value. That means we need to find another way to
> handle copy relocations. I was hoping that someone could help with that.
I'd like to see this work go in. So long as it doesn't break existing
(non-linker namespace) use cases, I'm okay with fixing the other
problems later on.
Kevin
next prev parent reply other threads:[~2022-07-16 0:04 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 13:24 Markus Metzger
2022-06-02 13:25 ` [PATCH v5 01/15] gdb, testsuite: extend gdb_test_multiple checks Markus Metzger
2022-06-13 1:28 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 02/15] gdb, solib-svr4: remove locate_base() Markus Metzger
2022-06-02 23:04 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 03/15] gdb, gdbserver: support dlmopen() Markus Metzger
2022-06-19 4:02 ` Kevin Buettner
2022-06-27 12:55 ` Metzger, Markus T
2022-06-30 22:35 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 04/15] gdbserver: move main_lm handling into caller Markus Metzger
2022-06-19 4:22 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 05/15] gdb, gdbserver: extend RSP to support namespaces Markus Metzger
2022-06-02 16:09 ` Eli Zaretskii
2022-06-19 4:32 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 06/15] gdb, compile: unlink objfile stored in module Markus Metzger
2022-06-23 17:20 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 07/15] gdb, python: use gdbarch_iterate_over_objfiles_in_search_order Markus Metzger
2022-06-24 17:18 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles Markus Metzger
2022-06-24 17:26 ` Kevin Buettner
2022-07-18 16:49 ` Tom Tromey
2022-07-18 5:35 ` Metzger, Markus T
2022-09-14 8:19 ` Metzger, Markus T
2022-09-14 8:37 ` Joel Brobecker
2022-09-14 8:45 ` Metzger, Markus T
2022-06-02 13:25 ` [PATCH v5 09/15] gdb, ada: update ada_lookup_simple_minsym Markus Metzger
2022-06-24 23:42 ` Kevin Buettner
2022-07-18 17:02 ` Tom Tromey
2022-07-19 7:14 ` Metzger, Markus T
2022-09-14 8:19 ` Metzger, Markus T
2022-09-21 16:11 ` Tom Tromey
2022-06-02 13:25 ` [PATCH v5 10/15] gdb, ada: update ada_add_all_symbols Markus Metzger
2022-06-24 23:53 ` Kevin Buettner
2022-07-18 5:36 ` Metzger, Markus T
2022-07-18 16:56 ` Tom Tromey
2022-07-19 7:13 ` Metzger, Markus T
2022-07-19 12:23 ` Tom Tromey
2022-07-19 13:49 ` Metzger, Markus T
2022-06-02 13:25 ` [PATCH v5 11/15] gdb, cp: update add_symbol_overload_list_qualified Markus Metzger
2022-06-24 23:59 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 12/15] gdb, hppa: remove unused hppa_lookup_stub_minimal_symbol Markus Metzger
2022-06-25 0:01 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 13/15] gdb, symtab: inline find_quick_global_symbol_language Markus Metzger
2022-06-25 0:16 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 14/15] gdb: update gnu ifunc resolve Markus Metzger
2022-06-25 0:34 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 15/15] gdb, solib-svr4: support namespaces in DSO iteration Markus Metzger
2022-06-25 0:42 ` Kevin Buettner
2022-07-15 10:30 ` [PATCH v5 00/15] basic linker namespace support Metzger, Markus T
2022-07-16 0:04 ` Kevin Buettner [this message]
2022-07-18 5:33 ` Metzger, Markus T
2022-10-05 11:16 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220715170453.1d5142e2@f35-zws-1 \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=markus.t.metzger@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).