From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tromey@adacore.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Kevin Buettner <kevinb@redhat.com>
Subject: RE: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles
Date: Wed, 14 Sep 2022 08:45:31 +0000 [thread overview]
Message-ID: <DM8PR11MB57492766E5E66875F2394B70DE469@DM8PR11MB5749.namprd11.prod.outlook.com> (raw)
In-Reply-To: <YyGS5+cNDuBm3CAw@adacore.com>
Thanks, Joel,
I'm not getting some emails, it seems. Or they get filtered away. Let me check.
regards,
markus.
>-----Original Message-----
>From: Joel Brobecker <brobecker@adacore.com>
>Sent: Mittwoch, 14. September 2022 10:38
>To: Metzger, Markus T <markus.t.metzger@intel.com>
>Cc: Tom Tromey <tromey@adacore.com>; gdb-patches@sourceware.org; Kevin
>Buettner <kevinb@redhat.com>; brobecker@adacore.com
>Subject: Re: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles
>
>Hi Markus,
>
>> would you be able to review this patch?
>
>I think Tom already reviewed this patch (back in July), and he said
>it looked fine to him. Here is the link to the email, in case I am
>mistaken:
>
> https://sourceware.org/pipermail/gdb-patches/2022-July/190855.html
>
>> >-----Original Message-----
>> >From: Metzger, Markus T <markus.t.metzger@intel.com>
>> >Sent: Montag, 18. Juli 2022 07:36
>> >To: brobecker@adacore.com
>> >Cc: gdb-patches@sourceware.org; Kevin Buettner <kevinb@redhat.com>
>> >Subject: RE: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles
>> >
>> >Hello Joel,
>> >
>> >Would you be able to review this Ada-related patch?
>> >
>> >thanks,
>> >markus.
>> >
>> >>-----Original Message-----
>> >>From: Metzger, Markus T <markus.t.metzger@intel.com>
>> >>Sent: Donnerstag, 2. Juni 2022 15:25
>> >>To: gdb-patches@sourceware.org
>> >>Subject: [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles
>> >>
>> >>When searching for standard exceptions for Ada, we lookup the minimal
>> >>symbol of each exception. With linker namespaces there can be multiple
>> >>instances in different namespaces. Collect them all.
>> >>---
>> >> gdb/ada-lang.c | 30 +++++++++++++++++++++++-------
>> >> 1 file changed, 23 insertions(+), 7 deletions(-)
>> >>
>> >>diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
>> >>index 6ab01fd27d4..2b251693b72 100644
>> >>--- a/gdb/ada-lang.c
>> >>+++ b/gdb/ada-lang.c
>> >>@@ -13016,15 +13016,29 @@ ada_add_standard_exceptions (compiled_regex
>> >>*preg,
>> >> {
>> >> if (preg == NULL || preg->exec (name, 0, NULL, 0) == 0)
>> >> {
>> >>- struct bound_minimal_symbol msymbol
>> >>- = ada_lookup_simple_minsym (name);
>> >>+ symbol_name_match_type match_type = name_match_type_from_name
>> >>(name);
>> >>+ lookup_name_info lookup_name (name, match_type);
>> >>
>> >>- if (msymbol.minsym != NULL)
>> >>- {
>> >>- struct ada_exc_info info
>> >>- = {name, msymbol.value_address ()};
>> >>+ symbol_name_matcher_ftype *match_name
>> >>+ = ada_get_symbol_name_matcher (lookup_name);
>> >>
>> >>- exceptions->push_back (info);
>> >>+ /* Iterate over all objfiles irrespective of scope or linker
>> >>+ namespaces so we get all exceptions anywhere in the
>> >>+ progspace. */
>> >>+ for (objfile *objfile : current_program_space->objfiles ())
>> >>+ {
>> >>+ for (minimal_symbol *msymbol : objfile->msymbols ())
>> >>+ {
>> >>+ if (match_name (msymbol->linkage_name (), lookup_name,
>> >>+ nullptr)
>> >>+ && msymbol->type () != mst_solib_trampoline)
>> >>+ {
>> >>+ ada_exc_info info
>> >>+ = {name, msymbol->value_address (objfile)};
>> >>+
>> >>+ exceptions->push_back (info);
>> >>+ }
>> >>+ }
>> >> }
>> >> }
>> >> }
>> >>@@ -13122,6 +13136,8 @@ ada_add_global_exceptions (compiled_regex
>*preg,
>> >> SEARCH_GLOBAL_BLOCK | SEARCH_STATIC_BLOCK,
>> >> VARIABLES_DOMAIN);
>> >>
>> >>+ /* Iterate over all objfiles irrespective of scope or linker namespaces
>> >>+ so we get all exceptions anywhere in the progspace. */
>> >> for (objfile *objfile : current_program_space->objfiles ())
>> >> {
>> >> for (compunit_symtab *s : objfile->compunits ())
>> >>--
>> >>2.35.3
>>
>> Intel Deutschland GmbH
>> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
>> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
>> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
>> Chairperson of the Supervisory Board: Nicole Lau
>> Registered Office: Munich
>> Commercial Register: Amtsgericht Muenchen HRB 186928
>>
>
>--
>Joel
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2022-09-14 8:45 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 13:24 [PATCH v5 00/15] basic linker namespace support Markus Metzger
2022-06-02 13:25 ` [PATCH v5 01/15] gdb, testsuite: extend gdb_test_multiple checks Markus Metzger
2022-06-13 1:28 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 02/15] gdb, solib-svr4: remove locate_base() Markus Metzger
2022-06-02 23:04 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 03/15] gdb, gdbserver: support dlmopen() Markus Metzger
2022-06-19 4:02 ` Kevin Buettner
2022-06-27 12:55 ` Metzger, Markus T
2022-06-30 22:35 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 04/15] gdbserver: move main_lm handling into caller Markus Metzger
2022-06-19 4:22 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 05/15] gdb, gdbserver: extend RSP to support namespaces Markus Metzger
2022-06-02 16:09 ` Eli Zaretskii
2022-06-19 4:32 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 06/15] gdb, compile: unlink objfile stored in module Markus Metzger
2022-06-23 17:20 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 07/15] gdb, python: use gdbarch_iterate_over_objfiles_in_search_order Markus Metzger
2022-06-24 17:18 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 08/15] gdb, ada: collect standard exceptions in all objfiles Markus Metzger
2022-06-24 17:26 ` Kevin Buettner
2022-07-18 16:49 ` Tom Tromey
2022-07-18 5:35 ` Metzger, Markus T
2022-09-14 8:19 ` Metzger, Markus T
2022-09-14 8:37 ` Joel Brobecker
2022-09-14 8:45 ` Metzger, Markus T [this message]
2022-06-02 13:25 ` [PATCH v5 09/15] gdb, ada: update ada_lookup_simple_minsym Markus Metzger
2022-06-24 23:42 ` Kevin Buettner
2022-07-18 17:02 ` Tom Tromey
2022-07-19 7:14 ` Metzger, Markus T
2022-09-14 8:19 ` Metzger, Markus T
2022-09-21 16:11 ` Tom Tromey
2022-06-02 13:25 ` [PATCH v5 10/15] gdb, ada: update ada_add_all_symbols Markus Metzger
2022-06-24 23:53 ` Kevin Buettner
2022-07-18 5:36 ` Metzger, Markus T
2022-07-18 16:56 ` Tom Tromey
2022-07-19 7:13 ` Metzger, Markus T
2022-07-19 12:23 ` Tom Tromey
2022-07-19 13:49 ` Metzger, Markus T
2022-06-02 13:25 ` [PATCH v5 11/15] gdb, cp: update add_symbol_overload_list_qualified Markus Metzger
2022-06-24 23:59 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 12/15] gdb, hppa: remove unused hppa_lookup_stub_minimal_symbol Markus Metzger
2022-06-25 0:01 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 13/15] gdb, symtab: inline find_quick_global_symbol_language Markus Metzger
2022-06-25 0:16 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 14/15] gdb: update gnu ifunc resolve Markus Metzger
2022-06-25 0:34 ` Kevin Buettner
2022-06-02 13:25 ` [PATCH v5 15/15] gdb, solib-svr4: support namespaces in DSO iteration Markus Metzger
2022-06-25 0:42 ` Kevin Buettner
2022-07-15 10:30 ` [PATCH v5 00/15] basic linker namespace support Metzger, Markus T
2022-07-16 0:04 ` Kevin Buettner
2022-07-18 5:33 ` Metzger, Markus T
2022-10-05 11:16 ` Metzger, Markus T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB57492766E5E66875F2394B70DE469@DM8PR11MB5749.namprd11.prod.outlook.com \
--to=markus.t.metzger@intel.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).