Re: [PATCH] gdb/csky support .reg2 for kernel 4.x and later

[Kevin Buettner <kevinb@redhat.com>]

On Fri, 22 Jul 2022 13:54:46 +0800
Jiangshuai Li via Gdb-patches <gdb-patches@sourceware.org> wrote:
 
>  static void
>  csky_supply_gregset (const struct regset *regset,
> -		     struct regcache *regcache, int regnum,
> -		     const void *regs, size_t len)
> +                     struct regcache *regcache, int regnum,
> +                     const void *regs, size_t len)
>  {
>    int i, gregset_num;
>    const gdb_byte *gregs = (const gdb_byte *) regs ;
> @@ -77,8 +79,8 @@ csky_supply_gregset (const struct regset *regset,
>    for (i = 0; i < gregset_num; i++)
>      {
>        if ((regnum == csky_gregset_offset[i] || regnum == -1)
> -	  && csky_gregset_offset[i] != -1)
> -	regcache->raw_supply (csky_gregset_offset[i], gregs + 4 * i);
> +          && csky_gregset_offset[i] != -1)
> +        regcache->raw_supply (csky_gregset_offset[i], gregs + 4 * i);
>      }
>  }
>  

So... in the above two hunks of this patch, plus in many other places
in the patch, it seems that the only change was to convert tabs to
spaces.

Could you please resend your patch without these whitespace changes? 

Not only will it be easier to review, but I think we still prefer the
use of tabs in place of leading spaces in GDB's source code.  Even if
such a change were desirable, we'd prefer to see a separate patch for
whitespace changes.

Thanks,

Kevin