Re: [PATCH 1/2] gdb/testsuite: avoid creating files in gdb/testsuite directory

[Lancelot SIX <lsix@lancelotsix.com>]

Hi Andrew,

On Sun, Oct 02, 2022 at 03:43:56PM +0100, Andrew Burgess via Gdb-patches wrote:
> I spotted that the test gdb.dwarf2/dw2-using-debug-str.exp was
> creating an output file (called debug_str_section) in the root
> build/gdb/testsuite directory instead of using the
> build/gdb/testsuite/output/gdb.dwarf2/dw2-using-debug-str/ directory.
> 
> This is a result of not using standard_output_file in the test
> script.
> 
> With this commit the file is now placed in the expected output
> directory.  The test still passes for me.
> ---
>  gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp b/gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp
> index d27554f2f89..729961c99b5 100644
> --- a/gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp
> +++ b/gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp
> @@ -105,7 +105,8 @@ gdb_test "p global_var" " = \\{aa = 0, bb = 0, cc = 0\\}"
>  # cc-with-dwz-m.exp and cc-with-gnu-debuglink.exp.  Handle this by
>  # skipping the remainder of the test-case.
>  set debug_str_section "${binfile}-debug-str"
> -set args "--dump-section .debug_str=debug_str_section $binfile"
> +set debug_str_file [standard_output_file "debug_str_section"]
> +set args "--dump-section .debug_str=${debug_str_file} $binfile"

Just above your change, there is the following line:

  set debug_str_section "${binfile}-debug-str"

I believe that the original intent was to use this as output file name,
but the '$' was use in the set args line.

It looks to me that the change should be:

  -set args "--dump-section .debug_str=debug_str_section $binfile"
  +set args "--dump-section .debug_str=$debug_str_section $binfile"

If you prefer your change, the `set debug_str_section` line should be
removed.

Best,
Lancelot.
>  set result [remote_exec host "[gdb_find_objcopy] $args"]
>  set status [lindex $result 0]
>  set output [lindex $result 1]
> -- 
> 2.25.4
>