Re: [PATCH 1/2] gdb/testsuite: avoid creating files in gdb/testsuite directory

[Pedro Alves <pedro@palves.net>]

On 2022-10-03 5:06 p.m., Andrew Burgess via Gdb-patches wrote:
> Lancelot SIX <lsix@lancelotsix.com> writes:
> 

>> Just above your change, there is the following line:
>>
>>   set debug_str_section "${binfile}-debug-str"
>>
>> I believe that the original intent was to use this as output file name,
>> but the '$' was use in the set args line.
>>
>> It looks to me that the change should be:
>>
>>   -set args "--dump-section .debug_str=debug_str_section $binfile"
>>   +set args "--dump-section .debug_str=$debug_str_section $binfile"
>>
>> If you prefer your change, the `set debug_str_section` line should be
>> removed.
> 
> Good spot.
> 
> Updated patch below.

I'm glad you guys found this alternative approach.  I was going to suggest
to see if we could avoid changing directory, the "cd" approach IMO should be
avoided if possible.  The reason is that when you change gdb's directory to
the test's output dir, if GDB crashes and produces a core on teardown, then that core will
end up in the test's output directory, and thus won't be noticed by the spurious core
detection, i.e., won't be signaled in gdb.sum.