public inbox for
 help / color / mirror / Atom feed
From: Nils-Christian Kempke <>
	Nils-Christian Kempke <>
Subject: [PATCH v2 0/4] Dynamic properties of pointers
Date: Wed,  5 Oct 2022 22:40:35 +0200	[thread overview]
Message-ID: <> (raw)


Please find attached v2 of this series.  The main change is patch 3
which became a 'some compiler DWARF that is wrong but we still want to
support it' patch after a discussion in
and thanks to Simon and Zoran.  They convinced me that my v1 was wrong.

V1 can be found here:

Changes since v1:

  * Patch 1 is unchanged and was already approved by Simon in v1.

  * Patch 2:
  Patch 2 changed quite a bit ang mainly got simpler.  Initially I
  thought here that DW_TAG_pointer_type could actually have the
  DW_AT_associated attribute, but it turned out that this again was an
  icc/icpc/ifort DWARF peculiarity.  The part handling this attribute
  for dynamic pointer types got moved to patch 3.  As a result, I could
  use the same handling for resolving dynamic pointers and references
  in resolve_dynamic_type_internal which made the patch simpler.
  I fixed the Simons' leftover comments in

  * Patch 3:
  From patch 2 the DW_AT_associated handling moved to this patch.
  Additionally, I wrapped all changed in this patch in compiler guards
  checking for icc/icpc/ifort and added a dwarf2 tests more concretely
  describing the poor Intel classic compiler DWARF we want to support
  here.  Last, I rewrote the commit message and added some comments.

  * Patch 4: Added a comment to the loop in the testcase.

I am not sure whether I did patch 3 the 'normal/usual' way compiler
quirks are implemented in GDB.  Have a look!  I'm looking forward to


Bernhard Heckel (1):
  gdb/types: Resolve pointer types dynamically

Nils-Christian Kempke (3):
  gdb, testsuite: handle icc and icpc deprecated remarks
  gdb, typeprint: workaround icc/icpc/ifort pointer/reference DWARF
  gdb/fortran: Fix sizeof intrinsic for Fortran

 gdb/eval.c                                    |   3 +
 gdb/gdbtypes.c                                |  86 ++++++++-
 gdb/gdbtypes.h                                |   5 +
 gdb/testsuite/gdb.cp/               |   4 +
 gdb/testsuite/gdb.cp/vla-cxx.exp              |  31 ++++
 gdb/testsuite/gdb.dwarf2/dynarr-ptr.exp       |  16 +-
 .../icc-ifort-pointers-and-references.c       |  37 ++++
 .../icc-ifort-pointers-and-references.exp     | 150 +++++++++++++++
 .../gdb.fortran/pointer-to-pointer.exp        |   2 +-
 gdb/testsuite/gdb.fortran/pointers.exp        | 172 ++++++++++++++++++
 gdb/testsuite/gdb.fortran/pointers.f90        |  29 +++
 gdb/testsuite/gdb.fortran/sizeof.exp          | 115 ++++++++++++
 gdb/testsuite/gdb.fortran/sizeof.f90          | 108 +++++++++++
 gdb/testsuite/lib/gdb.exp                     |  18 ++
 gdb/valprint.c                                |  40 +++-
 15 files changed, 796 insertions(+), 20 deletions(-)
 create mode 100644 gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.c
 create mode 100644 gdb/testsuite/gdb.dwarf2/icc-ifort-pointers-and-references.exp
 create mode 100644 gdb/testsuite/gdb.fortran/pointers.exp
 create mode 100644 gdb/testsuite/gdb.fortran/sizeof.exp
 create mode 100644 gdb/testsuite/gdb.fortran/sizeof.f90


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, <>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

             reply	other threads:[~2022-10-05 20:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-05 20:40 Nils-Christian Kempke [this message]
2022-10-05 20:40 ` [PATCH v2 1/4] gdb, testsuite: handle icc and icpc deprecated remarks Nils-Christian Kempke
2022-10-05 20:40 ` [PATCH v2 2/4] gdb/types: Resolve pointer types dynamically Nils-Christian Kempke
2023-01-05 19:35   ` Tom Tromey
2022-10-05 20:40 ` [PATCH v2 3/4] gdb, typeprint: workaround icc/icpc/ifort pointer/reference DWARF Nils-Christian Kempke
2023-01-05 19:46   ` Tom Tromey
2022-10-05 20:40 ` [PATCH v2 4/4] gdb/fortran: Fix sizeof intrinsic for Fortran Nils-Christian Kempke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).