From: Tom Tromey <tom@tromey.com>
To: Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org>
Cc: Nils-Christian Kempke <nils-christian.kempke@intel.com>,
simark@simark.ca, Bernhard Heckel <bernhard.heckel@intel.com>
Subject: Re: [PATCH v2 2/4] gdb/types: Resolve pointer types dynamically
Date: Thu, 05 Jan 2023 12:35:05 -0700 [thread overview]
Message-ID: <87pmbsepw6.fsf@tromey.com> (raw)
In-Reply-To: <20221005204039.575255-3-nils-christian.kempke@intel.com> (Nils-Christian Kempke via Gdb-patches's message of "Wed, 5 Oct 2022 22:40:37 +0200")
>>>>> Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org> writes:
> - if (type_not_associated (value_type (val)))
> - {
> - val_print_not_associated (stream);
> - return 0;
> - }
> -
I don't really understand the importance of this hunk, but I do see what
appear to be tests for this output, so if those still pass I suppose
this code is redundant and therefore the patch is ok.
Tom
next prev parent reply other threads:[~2023-01-05 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 20:40 [PATCH v2 0/4] Dynamic properties of pointers Nils-Christian Kempke
2022-10-05 20:40 ` [PATCH v2 1/4] gdb, testsuite: handle icc and icpc deprecated remarks Nils-Christian Kempke
2022-10-05 20:40 ` [PATCH v2 2/4] gdb/types: Resolve pointer types dynamically Nils-Christian Kempke
2023-01-05 19:35 ` Tom Tromey [this message]
2022-10-05 20:40 ` [PATCH v2 3/4] gdb, typeprint: workaround icc/icpc/ifort pointer/reference DWARF Nils-Christian Kempke
2023-01-05 19:46 ` Tom Tromey
2022-10-05 20:40 ` [PATCH v2 4/4] gdb/fortran: Fix sizeof intrinsic for Fortran Nils-Christian Kempke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmbsepw6.fsf@tromey.com \
--to=tom@tromey.com \
--cc=bernhard.heckel@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=nils-christian.kempke@intel.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).