* [committed][gdb/testsuite] Remove unnecessary perror in some test-cases
@ 2022-10-12 14:50 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2022-10-12 14:50 UTC (permalink / raw)
To: gdb-patches
Hi,
On openSUSE Tumbleweed I noticed:
...
UNTESTED: gdb.dwarf2/fission-absolute-dwo.exp: fission-absolute-dwo.exp
ERROR: failed to compile fission-absolute-dwo
...
The ERROR is unnecessary, given that an UNTESTED is already emitted.
Furthermore, it could be argued that it is incorrect because it's not a
testsuite error to not be able to compile something, and UNTESTED or
UNSUPPORTED is more appropriate.
Remove the perror call, likewise in fission-relative-dwo.exp.
Tested on x86_64-linux.
Committed to trunk.
Thanks,
- Tom
[gdb/testsuite] Remove unnecessary perror in some test-cases
---
gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp | 1 -
gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp | 1 -
2 files changed, 2 deletions(-)
diff --git a/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp b/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp
index e243598841e..53150237408 100644
--- a/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp
+++ b/gdb/testsuite/gdb.dwarf2/fission-absolute-dwo.exp
@@ -112,7 +112,6 @@ set object_file [standard_output_file ${testfile}.o]
if { [build_executable_and_dwo_files "${testfile}.exp" ${binfile} {nodebug} \
[list $asm_file {nodebug split-dwo} ${object_file}] \
[list $srcfile {nodebug}]] } {
- perror "failed to compile ${gdb_test_file_name}"
return -1
}
diff --git a/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp b/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp
index 62d79412582..3b548c4e8b5 100644
--- a/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp
+++ b/gdb/testsuite/gdb.dwarf2/fission-relative-dwo.exp
@@ -109,7 +109,6 @@ set object_file [standard_output_file ${testfile}.o]
if { [build_executable_and_dwo_files "${testfile}.exp" ${testfile} {nodebug} \
[list $asm_file {nodebug split-dwo} ${object_file}] \
[list $srcfile {nodebug}]] } {
- perror "failed to compile ${gdb_test_file_name}"
return -1
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-12 14:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-12 14:50 [committed][gdb/testsuite] Remove unnecessary perror in some test-cases Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).