From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [committed][gdb/testsuite] Drop unnecessary -Wl,-soname in gdb.base/skip-solib.exp
Date: Fri, 14 Oct 2022 13:11:22 +0200 [thread overview]
Message-ID: <20221014111119.GA11309@delia.home> (raw)
Hi,
I noticed in gdb.base/skip-solib.exp:
...
if {[gdb_compile_shlib ${srcdir}/${subdir}/${srcfile_lib} ${binfile_lib} \
[list debug -Wl,-soname,${libname}.so]] != ""} {
return -1
}
...
that the -Wl,-soname argument is missing an ldflags= prefix, but adding it
gives us a duplicate:
...
Executing on host: gcc -fno-stack-protector \
outputs/gdb.base/skip-solib/skip-solib-lib.c.o -fdiagnostics-color=never \
-shared -g -Wl,-soname,libskip-solib.so -Wl,-soname,libskip-solib.so -lm \
-o outputs/gdb.base/skip-solib/libskip-solib.so (timeout = 300)
...
so apparently it's taken care of by gdb_compile_shlib.
Drop the inactive and also unnecessary -Wl,-soname,${libname}.so from the
flags list for the gdb_compile_shlib call.
Tested on x86_64-linux.
Committed to trunk.
Thanks,
- Tom
[gdb/testsuite] Drop unnecessary -Wl,-soname in gdb.base/skip-solib.exp
---
gdb/testsuite/gdb.base/skip-solib.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.base/skip-solib.exp b/gdb/testsuite/gdb.base/skip-solib.exp
index 9af39d829c0..49539bb6695 100644
--- a/gdb/testsuite/gdb.base/skip-solib.exp
+++ b/gdb/testsuite/gdb.base/skip-solib.exp
@@ -41,7 +41,7 @@ set binfile_lib [standard_output_file ${libname}.so]
#
if {[gdb_compile_shlib ${srcdir}/${subdir}/${srcfile_lib} ${binfile_lib} \
- [list debug -Wl,-soname,${libname}.so]] != ""} {
+ [list debug]] != ""} {
return -1
}
reply other threads:[~2022-10-14 11:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014111119.GA11309@delia.home \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).