* [pushed] [gdb/testsuite] Remove address from test names
@ 2022-10-27 15:15 Tom de Vries
0 siblings, 0 replies; only message in thread
From: Tom de Vries @ 2022-10-27 15:15 UTC (permalink / raw)
To: gdb-patches
I noticed an address in a test name:
...
PASS: gdb.base/eh_return.exp: gdb_breakpoint: \
set breakpoint at *0x000000000040071b
...
Stabilize the test name by using "set breakpoint on address" instead.
Likewise in two other test-cases.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.base/eh_return.exp | 2 +-
gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp | 2 +-
gdb/testsuite/gdb.opt/inline-break.exp | 4 +++-
3 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/gdb.base/eh_return.exp b/gdb/testsuite/gdb.base/eh_return.exp
index 6e4b9bd0bba..a6dda78e013 100644
--- a/gdb/testsuite/gdb.base/eh_return.exp
+++ b/gdb/testsuite/gdb.base/eh_return.exp
@@ -73,7 +73,7 @@ if { $address == -1 } {
clean_restart ${binfile}
-gdb_breakpoint "*$address" message
+gdb_assert [gdb_breakpoint "*$address" no-message] "set breakpoint on address"
# The assert did not reproduce when running to main, and continuing to the
# breakpoint, so instead, run to the breakpoint.
diff --git a/gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp b/gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp
index 17537585ad2..2e479d6ebe2 100644
--- a/gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp
+++ b/gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp
@@ -45,7 +45,7 @@ if { $next_insn_addr == "" } {
return -1
}
-gdb_test "b *$next_insn_addr" "Breakpoint .*"
+gdb_test "b *$next_insn_addr" "Breakpoint .*" "set breakpoint on address"
# So that GDB doesn't try to remove the regular breakpoint when the
# step finishes.
diff --git a/gdb/testsuite/gdb.opt/inline-break.exp b/gdb/testsuite/gdb.opt/inline-break.exp
index 24dd6ebaf0a..708fd74aa1e 100644
--- a/gdb/testsuite/gdb.opt/inline-break.exp
+++ b/gdb/testsuite/gdb.opt/inline-break.exp
@@ -292,7 +292,9 @@ with_test_prefix "address" {
# Set the breakpoint by address, and check that GDB reports the
# breakpoint location being the inline function.
- gdb_test "break *$address" ".*Breakpoint .* at $address: file .*$srcfile, line $line."
+ gdb_test "break *$address" \
+ ".*Breakpoint .* at $address: file .*$srcfile, line $line." \
+ "set breakpoint on address"
gdb_test "info break \$bpnum" "in func1 at .*$srcfile:$line"
base-commit: 1dc83674da675a20ae361a037305777d23764574
--
2.35.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-10-27 15:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-27 15:15 [pushed] [gdb/testsuite] Remove address from test names Tom de Vries
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).