From: Mike Frysinger <vapier@gentoo.org>
To: gdb-patches@sourceware.org
Subject: [PATCH] sim: mips: call Unpredictable instead of setting bogus values [PR sim/29276]
Date: Fri, 4 Nov 2022 07:41:04 +0700 [thread overview]
Message-ID: <20221104004104.20150-1-vapier@gentoo.org> (raw)
The intention of this code seems to be to indicate that this insn
should not be used and produces undefined behavior, so instead of
setting registers to bogus values, call Unpredictable. This fixes
build warnings due to 32-bit/64-bit type conversions, and outputs
a log message for users at runtime instead of silent corruption.
Bug: https://sourceware.org/PR29276
---
sim/mips/mips.igen | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sim/mips/mips.igen b/sim/mips/mips.igen
index dfad42276155..0746a52d5ab1 100644
--- a/sim/mips/mips.igen
+++ b/sim/mips/mips.igen
@@ -1450,7 +1450,7 @@
else if ((fs & 0x1) == 0)
GPR[rt] = SET64HI (FGR[fs+1]) | FGR[fs];
else
- GPR[rt] = SET64HI (0xDEADC0DE) | 0xBAD0BAD0;
+ Unpredictable ();
TRACE_ALU_RESULT (GPR[rt]);
}
@@ -5782,7 +5782,7 @@
else if ((FS & 0x1) == 0)
v = SET64HI (FGR[FS+1]) | FGR[FS];
else
- v = SET64HI (0xDEADC0DE) | 0xBAD0BAD0;
+ Unpredictable ();
PENDING_FILL (RT, v);
TRACE_ALU_RESULT (v);
}
--
2.38.1
reply other threads:[~2022-11-04 0:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221104004104.20150-1-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).