From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH v2 2/2] gdb: add some debug statements to solib-svr4.c
Date: Mon, 28 Nov 2022 12:00:49 -0500 [thread overview]
Message-ID: <20221128170049.1094477-2-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <20221128170049.1094477-1-simon.marchi@polymtl.ca>
From: Simon Marchi <simon.marchi@efficios.com>
Add a few debug statements that were useful to me when debugging why the
glibc probes interface wasn't getting used.
Change-Id: Ic20744f9fc80a90f196896b0829949411620c540
---
gdb/solib-svr4.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c
index 6acaf87960bf..357059c09486 100644
--- a/gdb/solib-svr4.c
+++ b/gdb/solib-svr4.c
@@ -2168,6 +2168,9 @@ svr4_create_probe_breakpoints (svr4_info *info, struct gdbarch *gdbarch,
{
CORE_ADDR address = p->get_relocated_address (objfile);
+ solib_debug_printf ("name=%s, addr=%s", probe_info[i].name,
+ paddress (gdbarch, address));
+
create_solib_event_breakpoint (gdbarch, address);
register_solib_event_probe (info, objfile, p, address, action);
}
@@ -2185,6 +2188,9 @@ svr4_find_and_create_probe_breakpoints (svr4_info *info,
struct obj_section *os,
bool with_prefix)
{
+ SOLIB_SCOPED_DEBUG_START_END ("objfile=%s, with_prefix=%d",
+ os->objfile->original_name, with_prefix);
+
std::vector<probe *> probes[NUM_PROBES];
for (int i = 0; i < NUM_PROBES; i++)
@@ -2204,6 +2210,7 @@ svr4_find_and_create_probe_breakpoints (svr4_info *info,
}
probes[i] = find_probes_in_objfile (os->objfile, "rtld", name);
+ solib_debug_printf ("probe=%s, num found=%zu", name, probes[i].size ());
/* The "map_failed" probe did not exist in early
versions of the probes code in which the probes'
@@ -2237,6 +2244,7 @@ svr4_find_and_create_probe_breakpoints (svr4_info *info,
}
/* All probes found. Now create them. */
+ solib_debug_printf ("using probes interface");
svr4_create_probe_breakpoints (info, gdbarch, probes, os->objfile);
return true;
}
@@ -2262,7 +2270,11 @@ svr4_create_solib_event_breakpoints (svr4_info *info, struct gdbarch *gdbarch,
if (os == nullptr
|| (!svr4_find_and_create_probe_breakpoints (info, gdbarch, os, false)
&& !svr4_find_and_create_probe_breakpoints (info, gdbarch, os, true)))
- create_solib_event_breakpoint (gdbarch, address);
+ {
+ solib_debug_printf ("falling back to r_brk breakpoint: addr=%s",
+ paddress (gdbarch, address));
+ create_solib_event_breakpoint (gdbarch, address);
+ }
}
/* Helper function for gdb_bfd_lookup_symbol. */
--
2.38.1
next prev parent reply other threads:[~2022-11-28 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 17:00 [PATCH v2 1/2] gdb: merge solib-frv aix-solib debug options into "set/show debug solib" Simon Marchi
2022-11-28 17:00 ` Simon Marchi [this message]
2022-11-28 17:24 ` Eli Zaretskii
2022-11-28 18:29 ` Simon Marchi
2022-11-28 18:38 ` Eli Zaretskii
2022-12-02 19:44 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128170049.1094477-2-simon.marchi@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).