Re: [PATCH v2 1/2] gdb: merge solib-frv aix-solib debug options into "set/show debug solib"

[Simon Marchi <simon.marchi@polymtl.ca>]

On 11/28/22 12:24, Eli Zaretskii wrote:
>> Cc: Simon Marchi <simon.marchi@polymtl.ca>
>> Date: Mon, 28 Nov 2022 12:00:48 -0500
>> From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
>>
>> solib implementations are typically used one at a time.  So it will be
>> rare that you will want to enable debug for one solib kind, and
>> absolutely want to keep the others disabled.  To make things simpler,
>> instead of adding separate variables / macros / commands for each solib
>> implementation, merge the existing ones (frv and aix) into a unified
>> "set/show debug solib", with the solib_debug_printf macro.
>>
>> Change-Id: I6e18bbc7401724f37ae66681badb079d75ecf7fa
>> ---
>>  gdb/NEWS            | 12 ++++++
>>  gdb/doc/gdb.texinfo | 18 +++------
>>  gdb/solib-aix.c     | 39 +++----------------
>>  gdb/solib-frv.c     | 95 +++++++++++----------------------------------
>>  gdb/solib.c         | 16 +++++---
>>  gdb/solib.h         | 12 ++++++
>>  6 files changed, 68 insertions(+), 124 deletions(-)
> 
> OK for the documentation parts, thanks.
> 
> I wonder what the others think about removing those two commands?  Do we
> have any policy regarding that?  Maybe leave them as aliases for the new
> command?

Tom mentioned he's fine with it here:

  https://inbox.sourceware.org/gdb-patches/94b7d01e-509f-eeaa-ff04-90be8d860868@polymtl.ca/T/#m7f63f08de9db666a51ebbe165a916c51000736c3

Like I said earlier, I believe it's fine to change these debug commands.
They exist essentially for people debugging some trouble with GDB
itself, not for the everyday user.  I think it's fine to consider
them as maintenance commands (and even move them to the maint prefix one
day, as Tom mentioned).

Given I see them as maintenance commands, I'd rather not add aliases,
unless you have strong feelings about it.

Simon