From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH] [gdb/testsuite] Wait longer for core generation
Date: Wed, 30 Nov 2022 15:58:30 +0100 [thread overview]
Message-ID: <20221130145830.1535-1-tdevries@suse.de> (raw)
When I run the gdb testsuite on a powerpc64le-linux system with (slow) nfs
file system, I run into timeouts due to core generation, like for instance:
...
(gdb) gcore $outputs/gdb.ada/task_switch_in_core/crash.gcore^M
FAIL: gdb.ada/task_switch_in_core.exp: save a corefile (timeout)
...
Fix this by using with_timeout_factor 3 in gdb_gcore_cmd.
Tested on powerpc64le-linux.
---
gdb/testsuite/lib/gdb.exp | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 23e3cc0c2d4..f41fc1375aa 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -5730,13 +5730,19 @@ proc gdb_gcore_cmd {core test} {
global gdb_prompt
set result 0
- gdb_test_multiple "gcore $core" $test {
- -re "Saved corefile .*\[\r\n\]+$gdb_prompt $" {
- pass $test
- set result 1
- }
- -re "(?:Can't create a corefile|Target does not support core file generation\\.)\[\r\n\]+$gdb_prompt $" {
- unsupported $test
+
+ set re_unsupported \
+ "(?:Can't create a corefile|Target does not support core file generation\\.)"
+
+ with_timeout_factor 3 {
+ gdb_test_multiple "gcore $core" $test {
+ -re -wrap "Saved corefile .*" {
+ pass $test
+ set result 1
+ }
+ -re -wrap $re_unsupported {
+ unsupported $test
+ }
}
}
base-commit: 016c606c66ce4b98c220130b9046545b04254a4a
--
2.35.3
next reply other threads:[~2022-11-30 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 14:58 Tom de Vries [this message]
2022-11-30 21:25 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221130145830.1535-1-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).