From: Kevin Buettner <kevinb@redhat.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdb/dwarf: add some QUIT macros
Date: Thu, 1 Dec 2022 09:27:42 -0700 [thread overview]
Message-ID: <20221201092742.70e5e920@f35-zws-nvidia> (raw)
In-Reply-To: <20221201160144.1045410-1-simon.marchi@efficios.com>
On Thu, 1 Dec 2022 11:01:44 -0500
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> wrote:
> While testing the fix for PR 29105, I noticed I couldn't ctrl-C my way
> out of GDB expanding many symtabs. GDB was busy in a loop in
> cooked_index_functions::expand_symtabs_matching. Add a QUIT there. I
> also happened to see a spot in
> cooked_index_functions::expand_matching_symbols where a QUIT would be
> useful too, since we iterate over a potentially big number of index
> entries and expand CUs in the loop. Add one there too.
LGTM.
Kevin
next prev parent reply other threads:[~2022-12-01 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 16:01 Simon Marchi
2022-12-01 16:27 ` Kevin Buettner [this message]
2022-12-01 16:44 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221201092742.70e5e920@f35-zws-nvidia \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).