public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [pushed] Pass internal gdb flags to --configuration invocations
@ 2023-01-14 19:47 Tom Tromey
  0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2023-01-14 19:47 UTC (permalink / raw)
  To: gdb-patches; +Cc: Tom Tromey

The test suite uses the --configuration flag to feature-test gdb.
However, when I added this, I neglected to pass the internal gdbflags
to this, causing an error, which then caused failures in the test
suite (which would not be seen if you'd ever run "make install").

This patch fixes the bug.  Tested by removing my install tree first,
to verify that I could reproduce the failure.
---
 gdb/testsuite/lib/gdb-guile.exp | 2 +-
 gdb/testsuite/lib/gdb.exp       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/testsuite/lib/gdb-guile.exp b/gdb/testsuite/lib/gdb-guile.exp
index f2307372b8b..50189c8ed90 100644
--- a/gdb/testsuite/lib/gdb-guile.exp
+++ b/gdb/testsuite/lib/gdb-guile.exp
@@ -21,7 +21,7 @@ set ghex {[0-9a-f]+}
 # Return a 1 for configurations that support Guile scripting.
 
 gdb_caching_proc allow_guile_tests {
-    set output [exec $::GDB --configuration]
+    set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"]
     return [expr {[string first "--with-guile" $output] != -1}]
 }
 
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 5359315667e..68337bd235c 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -2450,7 +2450,7 @@ proc allow_rust_tests {} {
 # Return a 1 for configurations that support Python scripting.
 
 gdb_caching_proc allow_python_tests {
-    set output [remote_exec host $::GDB --configuration]
+    set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"]
     return [expr {[string first "--with-python" $output] != -1}]
 }
 
@@ -2575,7 +2575,7 @@ gdb_caching_proc allow_dlmopen_tests {
 # Return 1 if we should allow TUI-related tests.
 
 gdb_caching_proc allow_tui_tests {
-    set output [remote_exec host $::GDB --configuration]
+    set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"]
     return [expr {[string first "--enable-tui" $output] != -1}]
 }
 
-- 
2.39.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-14 19:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-14 19:47 [pushed] Pass internal gdb flags to --configuration invocations Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).