From: Mark Wielaard <mark@klomp.org>
To: gdb-patches@sourceware.org
Cc: Sam James <sam@gentoo.org>, Mike Frysinger <vapier@gentoo.org>,
Mark Wielaard <mark@klomp.org>
Subject: [PATCH] sim: common, microblaze, mn10300: handle signal.h defining REC_PC.
Date: Sun, 15 Jan 2023 00:28:05 +0100 [thread overview]
Message-ID: <20230114232805.827713-1-mark@klomp.org> (raw)
signal.h isn't needed in microblaze and mn10300 interp.c
so don't include it.
In common sim-events.c, sim-signal.c, nrun.c and dv-sockser.c we
do need signal.h, but check whether REG_PC is defined (and then
undefine it) before including the sim headers.
It breaks the build on sparc because signal.h indirectly
includes /usr/include/sys/ucontext.h and defines REG_PC,
which is also defined in microblaze-opcm.h
---
sim/common/dv-sockser.c | 6 ++++++
sim/common/nrun.c | 6 ++++++
sim/common/sim-events.c | 6 ++++++
sim/common/sim-signal.c | 6 ++++++
sim/microblaze/interp.c | 1 -
sim/mn10300/interp.c | 2 --
6 files changed, 24 insertions(+), 3 deletions(-)
diff --git a/sim/common/dv-sockser.c b/sim/common/dv-sockser.c
index fba2775f2e8..db6ab8fc4be 100644
--- a/sim/common/dv-sockser.c
+++ b/sim/common/dv-sockser.c
@@ -39,6 +39,12 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include <sys/time.h>
#include <sys/types.h>
+/* signal.h might indirectly have defined some REG_ macros
+ which are also defined in the sim headers. */
+#ifdef REG_PC
+#undef REG_PC
+#endif
+
#include "sim-main.h"
#include "sim-assert.h"
#include "sim-options.h"
diff --git a/sim/common/nrun.c b/sim/common/nrun.c
index 4c011627bb8..6ad2b19fb0d 100644
--- a/sim/common/nrun.c
+++ b/sim/common/nrun.c
@@ -29,6 +29,12 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include "bfd.h"
#include "environ.h"
+/* signal.h might indirectly have defined some REG_ macros
+ which are also defined in the sim headers. */
+#ifdef REG_PC
+#undef REG_PC
+#endif
+
#include "sim-main.h"
#include "sim-signal.h"
#include "sim/callback.h"
diff --git a/sim/common/sim-events.c b/sim/common/sim-events.c
index e2afe2be6c5..ce3a5dc1652 100644
--- a/sim/common/sim-events.c
+++ b/sim/common/sim-events.c
@@ -33,6 +33,12 @@
#include "libiberty.h"
+/* signal.h might indirectly have defined some REG_ macros
+ which are also defined in the sim headers. */
+#ifdef REG_PC
+#undef REG_PC
+#endif
+
#include "sim-main.h"
#include "sim-assert.h"
#include "sim-cpu.h"
diff --git a/sim/common/sim-signal.c b/sim/common/sim-signal.c
index 9c4e261fa21..94d5d9d51c9 100644
--- a/sim/common/sim-signal.c
+++ b/sim/common/sim-signal.c
@@ -22,6 +22,12 @@ along with this program. If not, see <http://www.gnu.org/licenses/>. */
#include <signal.h>
+/* signal.h might indirectly have defined some REG_ macros
+ which are also defined in the sim headers. */
+#ifdef REG_PC
+#undef REG_PC
+#endif
+
#include "sim-main.h"
#include "sim-signal.h"
diff --git a/sim/microblaze/interp.c b/sim/microblaze/interp.c
index a4f505e77a8..f53c1d7d65b 100644
--- a/sim/microblaze/interp.c
+++ b/sim/microblaze/interp.c
@@ -19,7 +19,6 @@
/* This must come before any other includes. */
#include "defs.h"
-#include <signal.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
diff --git a/sim/mn10300/interp.c b/sim/mn10300/interp.c
index 2915551253f..07c3b8c900f 100644
--- a/sim/mn10300/interp.c
+++ b/sim/mn10300/interp.c
@@ -1,8 +1,6 @@
/* This must come before any other includes. */
#include "defs.h"
-#include <signal.h>
-
#include "sim-main.h"
#include "sim-options.h"
#include "sim-hw.h"
--
2.31.1
next reply other threads:[~2023-01-14 23:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 23:28 Mark Wielaard [this message]
2023-01-15 0:22 ` Mike Frysinger
2023-01-15 0:58 ` Sam James
2023-01-15 8:07 ` Mike Frysinger
2023-01-15 17:48 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230114232805.827713-1-mark@klomp.org \
--to=mark@klomp.org \
--cc=gdb-patches@sourceware.org \
--cc=sam@gentoo.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).