From: Mike Frysinger <vapier@gentoo.org>
To: Mark Wielaard <mark@klomp.org>
Cc: gdb-patches@sourceware.org, Sam James <sam@gentoo.org>
Subject: Re: [PATCH] sim: common, microblaze, mn10300: handle signal.h defining REC_PC.
Date: Sat, 14 Jan 2023 19:22:29 -0500 [thread overview]
Message-ID: <Y8NHRQHwYtS4joYo@vapier> (raw)
In-Reply-To: <20230114232805.827713-1-mark@klomp.org>
[-- Attachment #1: Type: text/plain, Size: 740 bytes --]
On 15 Jan 2023 00:28, Mark Wielaard wrote:
> signal.h isn't needed in microblaze and mn10300 interp.c
> so don't include it.
these changes are fine to merge if you want to split it out
> In common sim-events.c, sim-signal.c, nrun.c and dv-sockser.c we
> do need signal.h, but check whether REG_PC is defined (and then
> undefine it) before including the sim headers.
>
> It breaks the build on sparc because signal.h indirectly
> includes /usr/include/sys/ucontext.h and defines REG_PC,
> which is also defined in microblaze-opcm.h
i don't think this is correct. none of the files quoted use REG_PC,
so undefining a random symbol in them doesn't make sense. nothing in
sim/common/ uses REG_PC for that matter.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-01-15 0:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 23:28 Mark Wielaard
2023-01-15 0:22 ` Mike Frysinger [this message]
2023-01-15 0:58 ` Sam James
2023-01-15 8:07 ` Mike Frysinger
2023-01-15 17:48 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8NHRQHwYtS4joYo@vapier \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=mark@klomp.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).