From: "Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>
To: <gdb-patches@sourceware.org>
Cc: luis.machado@arm.com, tom@tromey.com,
"Torbjörn SVENSSON" <torbjorn.svensson@foss.st.com>,
"Yvan Roux" <yvan.roux@foss.st.com>
Subject: [PATCH v3 2/2] gdb/arm: Use new dwarf2 function cache
Date: Thu, 19 Jan 2023 11:29:50 +0100 [thread overview]
Message-ID: <20230119102948.3069226-2-torbjorn.svensson@foss.st.com> (raw)
In-Reply-To: <20230119102948.3069226-1-torbjorn.svensson@foss.st.com>
v2 -> v3:
No changes, just rebase.
---
This patch resolves the performance issue reported in pr/29738 by
caching the values for the stack pointers for the inner frame. By
doing so, the impact can be reduced to checking the state and
returning the appropriate value.
Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
Signed-off-by: Yvan Roux <yvan.roux@foss.st.com>
---
gdb/arm-tdep.c | 96 +++++++++++++++++++++++++++++++++-----------------
1 file changed, 64 insertions(+), 32 deletions(-)
diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index 51ec5236af1..be7219ca66e 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -3964,6 +3964,18 @@ struct frame_base arm_normal_base = {
arm_normal_frame_base
};
+struct arm_dwarf2_prev_register_cache
+{
+ /* Cached value of the coresponding stack pointer for the inner frame. */
+ CORE_ADDR sp;
+ CORE_ADDR msp;
+ CORE_ADDR msp_s;
+ CORE_ADDR msp_ns;
+ CORE_ADDR psp;
+ CORE_ADDR psp_s;
+ CORE_ADDR psp_ns;
+};
+
static struct value *
arm_dwarf2_prev_register (frame_info_ptr this_frame, void **this_cache,
int regnum)
@@ -3972,6 +3984,48 @@ arm_dwarf2_prev_register (frame_info_ptr this_frame, void **this_cache,
arm_gdbarch_tdep *tdep = gdbarch_tdep<arm_gdbarch_tdep> (gdbarch);
CORE_ADDR lr;
ULONGEST cpsr;
+ struct arm_dwarf2_prev_register_cache *cache
+ = (struct arm_dwarf2_prev_register_cache *) dwarf2_frame_get_fn_data (
+ this_frame, this_cache, arm_dwarf2_prev_register);
+
+ if (!cache)
+ {
+ const unsigned int size = sizeof (struct arm_dwarf2_prev_register_cache);
+ cache = (struct arm_dwarf2_prev_register_cache *)
+ dwarf2_frame_allocate_fn_data (this_frame, this_cache,
+ arm_dwarf2_prev_register, size);
+
+ if (tdep->have_sec_ext)
+ {
+ cache->sp
+ = get_frame_register_unsigned (this_frame, ARM_SP_REGNUM);
+
+ cache->msp_s
+ = get_frame_register_unsigned (this_frame,
+ tdep->m_profile_msp_s_regnum);
+ cache->msp_ns
+ = get_frame_register_unsigned (this_frame,
+ tdep->m_profile_msp_ns_regnum);
+ cache->psp_s
+ = get_frame_register_unsigned (this_frame,
+ tdep->m_profile_psp_s_regnum);
+ cache->psp_ns
+ = get_frame_register_unsigned (this_frame,
+ tdep->m_profile_psp_ns_regnum);
+ }
+ else if (tdep->is_m)
+ {
+ cache->sp
+ = get_frame_register_unsigned (this_frame, ARM_SP_REGNUM);
+
+ cache->msp
+ = get_frame_register_unsigned (this_frame,
+ tdep->m_profile_msp_regnum);
+ cache->psp
+ = get_frame_register_unsigned (this_frame,
+ tdep->m_profile_psp_regnum);
+ }
+ }
if (regnum == ARM_PC_REGNUM)
{
@@ -4011,33 +4065,18 @@ arm_dwarf2_prev_register (frame_info_ptr this_frame, void **this_cache,
if (tdep->have_sec_ext)
{
- CORE_ADDR sp
- = get_frame_register_unsigned (this_frame, ARM_SP_REGNUM);
- CORE_ADDR msp_s
- = get_frame_register_unsigned (this_frame,
- tdep->m_profile_msp_s_regnum);
- CORE_ADDR msp_ns
- = get_frame_register_unsigned (this_frame,
- tdep->m_profile_msp_ns_regnum);
- CORE_ADDR psp_s
- = get_frame_register_unsigned (this_frame,
- tdep->m_profile_psp_s_regnum);
- CORE_ADDR psp_ns
- = get_frame_register_unsigned (this_frame,
- tdep->m_profile_psp_ns_regnum);
-
bool is_msp = (regnum == tdep->m_profile_msp_regnum)
- && (msp_s == sp || msp_ns == sp);
+ && (cache->msp_s == cache->sp || cache->msp_ns == cache->sp);
bool is_msp_s = (regnum == tdep->m_profile_msp_s_regnum)
- && (msp_s == sp);
+ && (cache->msp_s == cache->sp);
bool is_msp_ns = (regnum == tdep->m_profile_msp_ns_regnum)
- && (msp_ns == sp);
+ && (cache->msp_ns == cache->sp);
bool is_psp = (regnum == tdep->m_profile_psp_regnum)
- && (psp_s == sp || psp_ns == sp);
+ && (cache->psp_s == cache->sp || cache->psp_ns == cache->sp);
bool is_psp_s = (regnum == tdep->m_profile_psp_s_regnum)
- && (psp_s == sp);
+ && (cache->psp_s == cache->sp);
bool is_psp_ns = (regnum == tdep->m_profile_psp_ns_regnum)
- && (psp_ns == sp);
+ && (cache->psp_ns == cache->sp);
override_with_sp_value = is_msp || is_msp_s || is_msp_ns
|| is_psp || is_psp_s || is_psp_ns;
@@ -4045,17 +4084,10 @@ arm_dwarf2_prev_register (frame_info_ptr this_frame, void **this_cache,
}
else if (tdep->is_m)
{
- CORE_ADDR sp
- = get_frame_register_unsigned (this_frame, ARM_SP_REGNUM);
- CORE_ADDR msp
- = get_frame_register_unsigned (this_frame,
- tdep->m_profile_msp_regnum);
- CORE_ADDR psp
- = get_frame_register_unsigned (this_frame,
- tdep->m_profile_psp_regnum);
-
- bool is_msp = (regnum == tdep->m_profile_msp_regnum) && (sp == msp);
- bool is_psp = (regnum == tdep->m_profile_psp_regnum) && (sp == psp);
+ bool is_msp = (regnum == tdep->m_profile_msp_regnum)
+ && (cache->sp == cache->msp);
+ bool is_psp = (regnum == tdep->m_profile_psp_regnum)
+ && (cache->sp == cache->psp);
override_with_sp_value = is_msp || is_psp;
}
--
2.25.1
next prev parent reply other threads:[~2023-01-19 10:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 10:29 [PATCH v3 1/2] gdb: dwarf2 generic implementation for caching function data Torbjörn SVENSSON
2023-01-19 10:29 ` Torbjörn SVENSSON [this message]
2023-01-25 16:55 ` [PATCH v3 2/2] gdb/arm: Use new dwarf2 function cache Luis Machado
2023-01-25 17:12 ` Simon Marchi
2023-01-25 20:15 ` Torbjorn SVENSSON
2023-01-19 16:53 ` [PATCH v3 1/2] gdb: dwarf2 generic implementation for caching function data Simon Marchi
2023-01-20 14:12 ` Torbjorn SVENSSON
2023-01-20 17:28 ` Simon Marchi
2023-01-20 17:33 ` Luis Machado
2023-01-20 17:43 ` Simon Marchi
2023-01-25 9:34 ` Torbjorn SVENSSON
2023-01-20 19:59 ` Tom Tromey
2023-01-25 9:39 ` Torbjorn SVENSSON
2023-01-25 16:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230119102948.3069226-2-torbjorn.svensson@foss.st.com \
--to=torbjorn.svensson@foss.st.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
--cc=tom@tromey.com \
--cc=yvan.roux@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).