Re: [PATCHv3] gdb: Replace memcpy with std::copy to avoid some g++ warnings on sparc

[Mark Wielaard <mark@klomp.org>]

Hi Simon,

On Tue, Jan 24, 2023 at 04:29:20PM -0500, Simon Marchi wrote:
> > diff --git a/gdb/fbsd-tdep.c b/gdb/fbsd-tdep.c
> > index 203390d9880..ebc15543149 100644
> > --- a/gdb/fbsd-tdep.c
> > +++ b/gdb/fbsd-tdep.c
> > @@ -662,8 +662,9 @@ fbsd_make_note_desc (enum target_object object, uint32_t structsize)
> >      return buf;
> >  
> >    gdb::byte_vector desc (sizeof (structsize) + buf->size ());
> > -  memcpy (desc.data (), &structsize, sizeof (structsize));
> > -  memcpy (desc.data () + sizeof (structsize), buf->data (), buf->size ());
> > +  std::copy (&structsize, &structsize + sizeof (structsize), desc.data ());
> > +  std::copy (buf->data (), desc.data () + sizeof (structsize),
> > +	     desc.data () + sizeof (structsize));
> 
> I think the second argument to the second std::copy call should have
> `buf->data ()`, not `desc.data ().  Otherwise, LGTM.  However, it would
> be nice to have the approval from John Baldwin.

Bah, what a stupid typo. You are right of course. Sorry. v4 coming up.

Thanks,

Mark