From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH v2 9/9] Move target check into allow_altivec_tests
Date: Tue, 24 Jan 2023 16:02:43 -0700 [thread overview]
Message-ID: <20230124230243.2471957-10-tom@tromey.com> (raw)
In-Reply-To: <20230124230243.2471957-1-tom@tromey.com>
Pedro pointed out that only PPC can possibly have altivec, so we can
move the target check into allow_altivec_tests.
---
gdb/testsuite/gdb.arch/altivec-abi.exp | 1 -
gdb/testsuite/gdb.arch/altivec-regs.exp | 1 -
gdb/testsuite/gdb.arch/powerpc-vector-regs.exp | 2 +-
gdb/testsuite/lib/gdb.exp | 5 +++++
4 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/gdb/testsuite/gdb.arch/altivec-abi.exp b/gdb/testsuite/gdb.arch/altivec-abi.exp
index 2cc75d4d617..b04858950e8 100644
--- a/gdb/testsuite/gdb.arch/altivec-abi.exp
+++ b/gdb/testsuite/gdb.arch/altivec-abi.exp
@@ -22,7 +22,6 @@
#
require allow_altivec_tests
-require {istarget "powerpc*"}
standard_testfile
diff --git a/gdb/testsuite/gdb.arch/altivec-regs.exp b/gdb/testsuite/gdb.arch/altivec-regs.exp
index 315ce1acfb2..6cc32aeff22 100644
--- a/gdb/testsuite/gdb.arch/altivec-regs.exp
+++ b/gdb/testsuite/gdb.arch/altivec-regs.exp
@@ -22,7 +22,6 @@
#
require allow_altivec_tests
-require {istarget "powerpc*"}
standard_testfile
diff --git a/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp b/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp
index 2447d740624..2958af019cb 100644
--- a/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp
+++ b/gdb/testsuite/gdb.arch/powerpc-vector-regs.exp
@@ -20,7 +20,7 @@
# 0 to 31 in each of the 16 bytes of each corresponding register, and
# we then check if gdb sees these same values.
-require allow_altivec_tests {[istarget "powerpc*"}
+require allow_altivec_tests
standard_testfile
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index d30340e1df1..e2af5a252b7 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3471,6 +3471,11 @@ gdb_caching_proc allow_altivec_tests {
return 0
}
+ if {![istarget powerpc*]} {
+ verbose "$me: PPC target required, returning 0" 2
+ return 0
+ }
+
# Make sure we have a compiler that understands altivec.
if [test_compiler_info gcc*] {
set compile_flags "additional_flags=-maltivec"
--
2.39.0
prev parent reply other threads:[~2023-01-24 23:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 23:02 [PATCH v2 0/9] Use 'require' even more Tom Tromey
2023-01-24 23:02 ` [PATCH v2 1/9] Convert skip_altivec_tests to allow form Tom Tromey
2023-01-25 10:54 ` Pedro Alves
2023-01-24 23:02 ` [PATCH v2 2/9] Rename skip_float_test " Tom Tromey
2023-01-24 23:02 ` [PATCH v2 3/9] Rename skip_power_isa_3_1_tests " Tom Tromey
2023-01-24 23:02 ` [PATCH v2 4/9] Rename skip_vsx_tests " Tom Tromey
2023-01-24 23:02 ` [PATCH v2 5/9] Use require with istarget Tom Tromey
2023-01-24 23:02 ` [PATCH v2 6/9] Introduce and use is_any_target Tom Tromey
2023-01-24 23:02 ` [PATCH v2 7/9] Add unsupported calls where needed Tom Tromey
2023-01-24 23:02 ` [PATCH v2 8/9] Use require with is_remote Tom Tromey
2023-01-24 23:02 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230124230243.2471957-10-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).