From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v2 1/9] Convert skip_altivec_tests to allow form
Date: Wed, 25 Jan 2023 10:54:31 +0000 [thread overview]
Message-ID: <40f9ff3f-ab5e-86e4-806f-8acda3767bb5@palves.net> (raw)
In-Reply-To: <20230124230243.2471957-2-tom@tromey.com>
On 2023-01-24 11:02 p.m., Tom Tromey wrote:
> -if {![istarget "powerpc*"] || [skip_altivec_tests]} {
> +require allow_altivec_tests
> +if {![istarget "powerpc*"]} {
> verbose "Skipping altivec abi tests."
> return
> }
I noticed that this transformation changed one thing -- we'd now run allow_altivec_tests,
and hence the compilation tests that allow_altivec_tests does, on all targets, while
before we wouldn't, since the istarget check used to be before the skip_altivec_tests check.
Functionally, it's the same, even though it slows down testing a tiny bit for non-powerpc targets.
In the end, you'd now added the patch that removes this istarget check in the last patch of the
series, so it's good as is, no need to change anything here.
I went to look whether the skip_power_isa_3_1_tests and skip_vsx_tests patches (patches #3 and #4) were
likewise affected (as those are similar and could also have the istarget check pushed
down), but in those you've kept the order:
-if {![istarget "powerpc*-*-linux*"] || [skip_vsx_tests]} {
+if {![istarget "powerpc*-*-linux*"]} {
verbose "Skipping PowerPC test for corefiles with VSX registers."
return
}
+require allow_vsx_tests
... so we're all good.
The whole series looks good to me.
next prev parent reply other threads:[~2023-01-25 10:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 23:02 [PATCH v2 0/9] Use 'require' even more Tom Tromey
2023-01-24 23:02 ` [PATCH v2 1/9] Convert skip_altivec_tests to allow form Tom Tromey
2023-01-25 10:54 ` Pedro Alves [this message]
2023-01-24 23:02 ` [PATCH v2 2/9] Rename skip_float_test " Tom Tromey
2023-01-24 23:02 ` [PATCH v2 3/9] Rename skip_power_isa_3_1_tests " Tom Tromey
2023-01-24 23:02 ` [PATCH v2 4/9] Rename skip_vsx_tests " Tom Tromey
2023-01-24 23:02 ` [PATCH v2 5/9] Use require with istarget Tom Tromey
2023-01-24 23:02 ` [PATCH v2 6/9] Introduce and use is_any_target Tom Tromey
2023-01-24 23:02 ` [PATCH v2 7/9] Add unsupported calls where needed Tom Tromey
2023-01-24 23:02 ` [PATCH v2 8/9] Use require with is_remote Tom Tromey
2023-01-24 23:02 ` [PATCH v2 9/9] Move target check into allow_altivec_tests Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40f9ff3f-ab5e-86e4-806f-8acda3767bb5@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).