public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org, Simon Marchi <simark@simark.ca>,
	Sam James <sam@gentoo.org>, John Baldwin <jhb@FreeBSD.org>
Subject: Re: [PATCHv4] gdb: Replace memcpy with std::copy to avoid some g++ warnings on sparc
Date: Wed, 25 Jan 2023 09:49:28 +0100	[thread overview]
Message-ID: <20230125084928.GI11538@gnu.wildebeest.org> (raw)
In-Reply-To: <87zga7ikx7.fsf@tromey.com>

Hi Tom,

On Tue, Jan 24, 2023 at 04:15:32PM -0700, Tom Tromey wrote:
> >>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:
> 
> Mark> -  memcpy (desc.data () + sizeof (structsize), buf->data (), buf->size ());
> ...
> Mark> +  std::copy (buf->data (), buf->data () + sizeof (structsize),
> Mark> +	     desc.data () + sizeof (structsize));
> 
> I think this should probably copy buf->size() bytes.
> So maybe buf->begin() and buf->end() ?

OK, sounds good. Will post a v5.

Cheers,

Mark

      reply	other threads:[~2023-01-25  8:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-24 22:31 Mark Wielaard
2023-01-24 23:15 ` Tom Tromey
2023-01-25  8:49   ` Mark Wielaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230125084928.GI11538@gnu.wildebeest.org \
    --to=mark@klomp.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@FreeBSD.org \
    --cc=sam@gentoo.org \
    --cc=simark@simark.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).