public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Lancelot SIX <lancelot.six@amd.com>
To: <gdb-patches@sourceware.org>
Cc: <lsix@lancelotsix.com>, Lancelot SIX <lancelot.six@amd.com>
Subject: [PATCH 0/4] Fix gdb.rocm/simple.exp on hosts without ROCm
Date: Tue, 7 Feb 2023 13:27:58 +0000	[thread overview]
Message-ID: <20230207132802.223510-1-lancelot.six@amd.com> (raw)

Hi,

Tom De Vries reported that the gdb.rocm/simple.exp test (recently introduced
with the AMDGPU support) can fails[1].  I can reproduce this problem
(and variations of it) on systems where GDB is not build with the AMDGPU
support, or which do not have the ROCm stack installed.

This series fixes this test failure by only running the test if:
- GDB is build with AMDGPU support (patch 1 and 3)
- if the hipcc compiler is installed and can compile a simple HIP
  program which offloads a task to an AMDGPU device (patch 4).

Patch 3 is a small refactoring to use "require" in gdb.rocm/*.exp.

All feedbacks are welcome.

Best,
Lancelot.

[1] https://sourceware.org/pipermail/gdb-patches/2023-February/196624.html

Lancelot SIX (4):
  gdb: 'show config' shows --with[out]-amd-dbgapi
  gdb/testsuite: Rename skip_hipcc_tests to allow_hipcc_tests
  gdb/testsuite: require amd-dbgapi support to run rocm tests
  gdb/testsuite: allow_hipcc_tests tests the hipcc compiler

 gdb/config.in                     |  3 ++
 gdb/configure                     |  3 ++
 gdb/configure.ac                  |  1 +
 gdb/testsuite/gdb.rocm/simple.exp |  5 +-
 gdb/testsuite/lib/gdb.exp         |  4 ++
 gdb/testsuite/lib/rocm.exp        | 80 +++++++++++++++++++++++++++++--
 gdb/top.c                         | 10 ++++
 7 files changed, 99 insertions(+), 7 deletions(-)


base-commit: ca2f51c6960d65c2d3adbc4095aa8a9d02759376
-- 
2.34.1


             reply	other threads:[~2023-02-07 13:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-07 13:27 Lancelot SIX [this message]
2023-02-07 13:27 ` [PATCH 1/4] gdb: 'show config' shows --with[out]-amd-dbgapi Lancelot SIX
2023-02-07 13:28 ` [PATCH 2/4] gdb/testsuite: Rename skip_hipcc_tests to allow_hipcc_tests Lancelot SIX
2023-02-07 13:28 ` [PATCH 3/4] gdb/testsuite: require amd-dbgapi support to run rocm tests Lancelot SIX
2023-02-07 13:59   ` Simon Marchi
2023-02-07 13:28 ` [PATCH 4/4] gdb/testsuite: allow_hipcc_tests tests the hipcc compiler Lancelot SIX
2023-02-07 13:42   ` Lancelot SIX
2023-02-07 14:12   ` Simon Marchi
2023-02-07 15:31     ` Lancelot SIX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230207132802.223510-1-lancelot.six@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).