From: Simon Marchi <simark@simark.ca>
To: Lancelot SIX <lancelot.six@amd.com>, gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com
Subject: Re: [PATCH 3/4] gdb/testsuite: require amd-dbgapi support to run rocm tests
Date: Tue, 7 Feb 2023 08:59:44 -0500 [thread overview]
Message-ID: <967b4fe3-905b-4b3b-603e-c0b8daabfb55@simark.ca> (raw)
In-Reply-To: <20230207132802.223510-4-lancelot.six@amd.com>
On 2/7/23 08:28, Lancelot SIX via Gdb-patches wrote:
> Update allow_hipcc_tests to check that GDB has the amd-dbgapi support
> built-in. Without this support, all tests using hipcc and the rocm
> stack will fail.
> ---
> gdb/testsuite/lib/rocm.exp | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/gdb/testsuite/lib/rocm.exp b/gdb/testsuite/lib/rocm.exp
> index 1440ac85d32..b5b59748c27 100644
> --- a/gdb/testsuite/lib/rocm.exp
> +++ b/gdb/testsuite/lib/rocm.exp
> @@ -22,6 +22,13 @@ proc allow_hipcc_tests { } {
> if {[target_info gdb_protocol] != ""} {
> return 0
> }
> +
> + # Ensure that GDB is built with amd-dbgapi support.
> + set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"]
> + if { [expr {[string first "--with-amd-dbgapi" $output] == -1}] } {
The expr is unnecessary. Otherwise, LGTM.
Simon
next prev parent reply other threads:[~2023-02-07 13:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 13:27 [PATCH 0/4] Fix gdb.rocm/simple.exp on hosts without ROCm Lancelot SIX
2023-02-07 13:27 ` [PATCH 1/4] gdb: 'show config' shows --with[out]-amd-dbgapi Lancelot SIX
2023-02-07 13:28 ` [PATCH 2/4] gdb/testsuite: Rename skip_hipcc_tests to allow_hipcc_tests Lancelot SIX
2023-02-07 13:28 ` [PATCH 3/4] gdb/testsuite: require amd-dbgapi support to run rocm tests Lancelot SIX
2023-02-07 13:59 ` Simon Marchi [this message]
2023-02-07 13:28 ` [PATCH 4/4] gdb/testsuite: allow_hipcc_tests tests the hipcc compiler Lancelot SIX
2023-02-07 13:42 ` Lancelot SIX
2023-02-07 14:12 ` Simon Marchi
2023-02-07 15:31 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=967b4fe3-905b-4b3b-603e-c0b8daabfb55@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).