From: Lancelot SIX <lancelot.six@amd.com>
To: <gdb-patches@sourceware.org>
Cc: <lsix@lancelotsix.com>, Lancelot SIX <lancelot.six@amd.com>
Subject: [PATCH v2 3/5] gdb/testsuite: require amd-dbgapi support to run rocm tests
Date: Thu, 9 Feb 2023 11:26:11 +0000 [thread overview]
Message-ID: <20230209112613.922098-4-lancelot.six@amd.com> (raw)
In-Reply-To: <20230209112613.922098-1-lancelot.six@amd.com>
Update allow_hipcc_tests to check that GDB has the amd-dbgapi support
built-in. Without this support, all tests using hipcc and the rocm
stack will fail.
---
gdb/testsuite/lib/rocm.exp | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/gdb/testsuite/lib/rocm.exp b/gdb/testsuite/lib/rocm.exp
index 1440ac85d32..a78b9f63353 100644
--- a/gdb/testsuite/lib/rocm.exp
+++ b/gdb/testsuite/lib/rocm.exp
@@ -22,6 +22,13 @@ proc allow_hipcc_tests { } {
if {[target_info gdb_protocol] != ""} {
return 0
}
+
+ # Ensure that GDB is built with amd-dbgapi support.
+ set output [remote_exec host $::GDB "$::INTERNAL_GDBFLAGS --configuration"]
+ if { [string first "--with-amd-dbgapi" $output] == -1 } {
+ return 0
+ }
+
return 1
}
--
2.34.1
next prev parent reply other threads:[~2023-02-09 11:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 11:26 [PATCH v2 0/5] Fix gdb.rocm/simple.exp on hosts without ROCm Lancelot SIX
2023-02-09 11:26 ` [PATCH v2 1/5] gdb: 'show config' shows --with[out]-amd-dbgapi Lancelot SIX
2023-02-09 11:26 ` [PATCH v2 2/5] gdb/testsuite: Rename skip_hipcc_tests to allow_hipcc_tests Lancelot SIX
2023-02-09 11:26 ` Lancelot SIX [this message]
2023-02-09 11:26 ` [PATCH v2 4/5] gdb/testsuite: allow_hipcc_tests tests the hipcc compiler Lancelot SIX
2023-02-09 11:26 ` [PATCH v2 5/5] gdb/testsuite: look for hipcc in env(ROCM_PATH) Lancelot SIX
2023-02-10 19:52 ` [PATCH v2 0/5] Fix gdb.rocm/simple.exp on hosts without ROCm Simon Marchi
2023-02-13 9:53 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230209112613.922098-4-lancelot.six@amd.com \
--to=lancelot.six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).