From: Simon Marchi <simark@simark.ca>
To: Lancelot SIX <lancelot.six@amd.com>, gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com
Subject: Re: [PATCH v2 0/5] Fix gdb.rocm/simple.exp on hosts without ROCm
Date: Fri, 10 Feb 2023 14:52:12 -0500 [thread overview]
Message-ID: <e60a9bcb-2c28-b266-41b1-6c37571688b5@simark.ca> (raw)
In-Reply-To: <20230209112613.922098-1-lancelot.six@amd.com>
On 2/9/23 06:26, Lancelot SIX via Gdb-patches wrote:
> Hi, this is a V2 for https://sourceware.org/pipermail/gdb-patches/2023-February/196653.html.
>
> Changes since V1:
>
> - Fixed a typo in patch 1
> - Removed the un-necessary "expr" call in patch 3
> - Added patch 5 so both hipcc and rocm_agent_enumerator are searched in
> a consistent way
>
> Best,
> Lancelot.
Thanks, that all LGTM:
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2023-02-10 19:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 11:26 Lancelot SIX
2023-02-09 11:26 ` [PATCH v2 1/5] gdb: 'show config' shows --with[out]-amd-dbgapi Lancelot SIX
2023-02-09 11:26 ` [PATCH v2 2/5] gdb/testsuite: Rename skip_hipcc_tests to allow_hipcc_tests Lancelot SIX
2023-02-09 11:26 ` [PATCH v2 3/5] gdb/testsuite: require amd-dbgapi support to run rocm tests Lancelot SIX
2023-02-09 11:26 ` [PATCH v2 4/5] gdb/testsuite: allow_hipcc_tests tests the hipcc compiler Lancelot SIX
2023-02-09 11:26 ` [PATCH v2 5/5] gdb/testsuite: look for hipcc in env(ROCM_PATH) Lancelot SIX
2023-02-10 19:52 ` Simon Marchi [this message]
2023-02-13 9:53 ` [PATCH v2 0/5] Fix gdb.rocm/simple.exp on hosts without ROCm Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e60a9bcb-2c28-b266-41b1-6c37571688b5@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=lancelot.six@amd.com \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).