public inbox for
 help / color / mirror / Atom feed
* [pushed] Constify ada_main_name
@ 2023-02-16 15:12 Tom Tromey
  0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2023-02-16 15:12 UTC (permalink / raw)
  To: gdb-patches; +Cc: Tom Tromey

Unlike the other *_main_name functions, ada_main_name returns a
non-const "char *".  This is strange, though, because the caller
should not in fact modify or free this pointer.  This patch changes
this function to constify its return type.
 gdb/ada-lang.c | 4 ++--
 gdb/ada-lang.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
index ec85729042f..b5afba30b4f 100644
--- a/gdb/ada-lang.c
+++ b/gdb/ada-lang.c
@@ -805,8 +805,8 @@ ada_update_initial_language (enum language lang)
    The result is good until the next call.  Return NULL if the main
    procedure doesn't appear to be in Ada.  */
-char *
-ada_main_name (void)
+const char *
+ada_main_name ()
   struct bound_minimal_symbol msym;
   static gdb::unique_xmalloc_ptr<char> main_program_name;
diff --git a/gdb/ada-lang.h b/gdb/ada-lang.h
index f018b2465f5..339c151798e 100644
--- a/gdb/ada-lang.h
+++ b/gdb/ada-lang.h
@@ -337,7 +337,7 @@ extern enum ada_renaming_category ada_parse_renaming (struct symbol *,
 extern void ada_find_printable_frame (frame_info_ptr fi);
-extern char *ada_main_name (void);
+extern const char *ada_main_name ();
 extern void create_ada_exception_catchpoint
   (struct gdbarch *gdbarch, enum ada_exception_catchpoint_kind ex_kind,

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-02-16 15:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-16 15:12 [pushed] Constify ada_main_name Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).