From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 1/2] gdb, python: do minor modernization in execute_gdb_command
Date: Fri, 24 Feb 2023 15:04:09 +0100 [thread overview]
Message-ID: <20230224140410.2647437-1-tankut.baris.aktemur@intel.com> (raw)
Use nullptr instead of NULL and boolify two local variables in
execute_gdb_command.
---
gdb/python/python.c | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/gdb/python/python.c b/gdb/python/python.c
index ed466cc4511..5719f351528 100644
--- a/gdb/python/python.c
+++ b/gdb/python/python.c
@@ -621,31 +621,32 @@ static PyObject *
execute_gdb_command (PyObject *self, PyObject *args, PyObject *kw)
{
const char *arg;
- PyObject *from_tty_obj = NULL, *to_string_obj = NULL;
- int from_tty, to_string;
- static const char *keywords[] = { "command", "from_tty", "to_string", NULL };
+ PyObject *from_tty_obj = nullptr;
+ PyObject *to_string_obj = nullptr;
+ static const char *keywords[] = { "command", "from_tty", "to_string",
+ nullptr };
if (!gdb_PyArg_ParseTupleAndKeywords (args, kw, "s|O!O!", keywords, &arg,
&PyBool_Type, &from_tty_obj,
&PyBool_Type, &to_string_obj))
- return NULL;
+ return nullptr;
- from_tty = 0;
- if (from_tty_obj)
+ bool from_tty = false;
+ if (from_tty_obj != nullptr)
{
int cmp = PyObject_IsTrue (from_tty_obj);
if (cmp < 0)
- return NULL;
- from_tty = cmp;
+ return nullptr;
+ from_tty = ((cmp == 0) ? false : true);
}
- to_string = 0;
- if (to_string_obj)
+ bool to_string = false;
+ if (to_string_obj != nullptr)
{
int cmp = PyObject_IsTrue (to_string_obj);
if (cmp < 0)
- return NULL;
- to_string = cmp;
+ return nullptr;
+ to_string = ((cmp == 0) ? false : true);
}
std::string to_string_res;
--
2.25.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next reply other threads:[~2023-02-24 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 14:04 Tankut Baris Aktemur [this message]
2023-02-24 14:04 ` [PATCH 2/2] gdb, python: selectively omit enabling stdin in gdb.execute exception Tankut Baris Aktemur
2023-02-24 19:43 ` Tom Tromey
2023-02-27 9:53 ` Aktemur, Tankut Baris
2023-02-24 19:37 ` [PATCH 1/2] gdb, python: do minor modernization in execute_gdb_command Tom Tromey
2023-02-25 11:08 ` Andrew Burgess
2023-02-27 9:34 ` Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224140410.2647437-1-tankut.baris.aktemur@intel.com \
--to=tankut.baris.aktemur@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).