From: Andrew Burgess <aburgess@redhat.com>
To: Tom Tromey <tom@tromey.com>,
Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Subject: Re: [PATCH 1/2] gdb, python: do minor modernization in execute_gdb_command
Date: Sat, 25 Feb 2023 11:08:00 +0000 [thread overview]
Message-ID: <875ybqj94f.fsf@redhat.com> (raw)
In-Reply-To: <87mt52hn22.fsf@tromey.com>
Tom Tromey <tom@tromey.com> writes:
>>>>>> "Tankut" == Tankut Baris Aktemur via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Tankut> Use nullptr instead of NULL and boolify two local variables in
> Tankut> execute_gdb_command.
>
> Seems fine.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tankut> + from_tty = ((cmp == 0) ? false : true);
>
> I'd probably write '= cmp != 0' but this is alright.
+1 from me. Please don't use: 'COND ? false : true'.
Thanks,
Andrew
next prev parent reply other threads:[~2023-02-25 11:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 14:04 Tankut Baris Aktemur
2023-02-24 14:04 ` [PATCH 2/2] gdb, python: selectively omit enabling stdin in gdb.execute exception Tankut Baris Aktemur
2023-02-24 19:43 ` Tom Tromey
2023-02-27 9:53 ` Aktemur, Tankut Baris
2023-02-24 19:37 ` [PATCH 1/2] gdb, python: do minor modernization in execute_gdb_command Tom Tromey
2023-02-25 11:08 ` Andrew Burgess [this message]
2023-02-27 9:34 ` Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ybqj94f.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tankut.baris.aktemur@intel.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).