From: Kevin Buettner <kevinb@redhat.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Make ui_out::do_progress_end 'private'
Date: Fri, 17 Mar 2023 15:20:59 -0700 [thread overview]
Message-ID: <20230317152059.0f8b4c52@f37-zws-nv> (raw)
In-Reply-To: <20230316193741.3804125-1-tromey@adacore.com>
On Thu, 16 Mar 2023 13:37:41 -0600
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> wrote:
> I noticed that ui_out::do_progress_end is public, just to support one
> use in debuginfod-support.c. This patch makes it private, updates
> progress_info to call it from its destructor, and finally changes
> debuginfod-support.c to follow.
> ---
> gdb/debuginfod-support.c | 101 ++++++++++++++++++++++-----------------
> gdb/ui-out.h | 8 ++--
> 2 files changed, 61 insertions(+), 48 deletions(-)
LGTM.
Kevin
prev parent reply other threads:[~2023-03-17 22:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 19:37 Tom Tromey
2023-03-17 22:20 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230317152059.0f8b4c52@f37-zws-nv \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).