* [PATCH] Use ui_out for "maint info frame-unwinders"
@ 2023-03-22 16:56 Tom Tromey
2023-04-07 15:18 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2023-03-22 16:56 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
This changes "maint info frame-unwinders" to use ui-out. This makes
the table slightly nicer. In general I think it's better to use
ui-out for tables.
---
gdb/frame-unwind.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/gdb/frame-unwind.c b/gdb/frame-unwind.c
index a3673dde77a..866b2e6b4a6 100644
--- a/gdb/frame-unwind.c
+++ b/gdb/frame-unwind.c
@@ -347,13 +347,22 @@ maintenance_info_frame_unwinders (const char *args, int from_tty)
struct gdbarch *gdbarch = target_gdbarch ();
struct frame_unwind_table *table = get_frame_unwind_table (gdbarch);
+ ui_out *uiout = current_uiout;
+ ui_out_emit_table table_emitter (uiout, 2, -1, "FrameUnwinders");
+ uiout->table_header (27, ui_left, "name", "Name");
+ uiout->table_header (25, ui_left, "type", "Type");
+ uiout->table_body ();
+
for (struct frame_unwind_table_entry *entry = table->list; entry != NULL;
entry = entry->next)
{
const char *name = entry->unwinder->name;
const char *type = frame_type_str (entry->unwinder->type);
- gdb_printf (gdb_stdout, "%-16s\t%-16s\n", name, type);
+ ui_out_emit_list tuple_emitter (uiout, nullptr);
+ uiout->field_string ("name", name);
+ uiout->field_string ("type", type);
+ uiout->text ("\n");
}
}
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Use ui_out for "maint info frame-unwinders"
2023-03-22 16:56 [PATCH] Use ui_out for "maint info frame-unwinders" Tom Tromey
@ 2023-04-07 15:18 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2023-04-07 15:18 UTC (permalink / raw)
To: Tom Tromey via Gdb-patches; +Cc: Tom Tromey
>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
Tom> This changes "maint info frame-unwinders" to use ui-out. This makes
Tom> the table slightly nicer. In general I think it's better to use
Tom> ui-out for tables.
I'm checking this in.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-07 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-22 16:56 [PATCH] Use ui_out for "maint info frame-unwinders" Tom Tromey
2023-04-07 15:18 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).