[PATCH] Add Ada test case for break using a label

[PATCH] Add Ada test case for break using a label

[Tom Tromey]

I noticed there aren't any Ada test cases for setting a breakpoint
using a label.  This patch adds one, adapted from the AdaCore test
suite.
---
 gdb/testsuite/gdb.ada/break-label.exp      | 30 ++++++++++++++++++++++
 gdb/testsuite/gdb.ada/break-label/pck.adb  | 21 +++++++++++++++
 gdb/testsuite/gdb.ada/break-label/pck.ads  | 18 +++++++++++++
 gdb/testsuite/gdb.ada/break-label/proc.adb | 22 ++++++++++++++++
 4 files changed, 91 insertions(+)
 create mode 100644 gdb/testsuite/gdb.ada/break-label.exp
 create mode 100644 gdb/testsuite/gdb.ada/break-label/pck.adb
 create mode 100644 gdb/testsuite/gdb.ada/break-label/pck.ads
 create mode 100644 gdb/testsuite/gdb.ada/break-label/proc.adb

diff --git a/gdb/testsuite/gdb.ada/break-label.exp b/gdb/testsuite/gdb.ada/break-label.exp
new file mode 100644
index 00000000000..15f661c2c9d
--- /dev/null
+++ b/gdb/testsuite/gdb.ada/break-label.exp
@@ -0,0 +1,30 @@
+# Copyright 2023 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+load_lib "ada.exp"
+
+require allow_ada_tests
+
+standard_ada_testfile proc
+
+if {[gdb_compile_ada "${srcfile}" "${binfile}" executable debug] != ""} {
+  return -1
+}
+
+# Ada is case-insensitive, so both of these should work.
+foreach_with_prefix name {break_here Break_Here} {
+    clean_restart ${testfile}
+    runto "proc:$name" message
+}
diff --git a/gdb/testsuite/gdb.ada/break-label/pck.adb b/gdb/testsuite/gdb.ada/break-label/pck.adb
new file mode 100644
index 00000000000..5ec9187895d
--- /dev/null
+++ b/gdb/testsuite/gdb.ada/break-label/pck.adb
@@ -0,0 +1,21 @@
+--  Copyright 2023 Free Software Foundation, Inc.
+--
+--  This program is free software; you can redistribute it and/or modify
+--  it under the terms of the GNU General Public License as published by
+--  the Free Software Foundation; either version 3 of the License, or
+--  (at your option) any later version.
+--
+--  This program is distributed in the hope that it will be useful,
+--  but WITHOUT ANY WARRANTY; without even the implied warranty of
+--  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+--  GNU General Public License for more details.
+--
+--  You should have received a copy of the GNU General Public License
+--  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+package body Pck is
+   procedure Do_Nothing is
+   begin
+      null;
+   end Do_Nothing;
+end Pck;
diff --git a/gdb/testsuite/gdb.ada/break-label/pck.ads b/gdb/testsuite/gdb.ada/break-label/pck.ads
new file mode 100644
index 00000000000..1d26905abdd
--- /dev/null
+++ b/gdb/testsuite/gdb.ada/break-label/pck.ads
@@ -0,0 +1,18 @@
+--  Copyright 2023 Free Software Foundation, Inc.
+--
+--  This program is free software; you can redistribute it and/or modify
+--  it under the terms of the GNU General Public License as published by
+--  the Free Software Foundation; either version 3 of the License, or
+--  (at your option) any later version.
+--
+--  This program is distributed in the hope that it will be useful,
+--  but WITHOUT ANY WARRANTY; without even the implied warranty of
+--  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+--  GNU General Public License for more details.
+--
+--  You should have received a copy of the GNU General Public License
+--  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+package Pck is
+   procedure Do_Nothing;
+end Pck;
diff --git a/gdb/testsuite/gdb.ada/break-label/proc.adb b/gdb/testsuite/gdb.ada/break-label/proc.adb
new file mode 100644
index 00000000000..d5d15768fdc
--- /dev/null
+++ b/gdb/testsuite/gdb.ada/break-label/proc.adb
@@ -0,0 +1,22 @@
+--  Copyright 2023 Free Software Foundation, Inc.
+--
+--  This program is free software; you can redistribute it and/or modify
+--  it under the terms of the GNU General Public License as published by
+--  the Free Software Foundation; either version 3 of the License, or
+--  (at your option) any later version.
+--
+--  This program is distributed in the hope that it will be useful,
+--  but WITHOUT ANY WARRANTY; without even the implied warranty of
+--  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+--  GNU General Public License for more details.
+--
+--  You should have received a copy of the GNU General Public License
+--  along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+with Pck; use Pck;
+
+procedure Proc is
+begin
+   <<break_here>>
+   Do_Nothing;
+end Proc;
-- 
2.39.1

Re: [PATCH] Add Ada test case for break using a label

[Tom Tromey]

>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> I noticed there aren't any Ada test cases for setting a breakpoint
Tom> using a label.  This patch adds one, adapted from the AdaCore test
Tom> suite.

I'm checking this in.

Tom