[PATCH] gdb: Don't overwrite CC when checking for BFD support

[orbea <orbea@riseup.net>]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

In gdb/acinclude.m4 'libtool' is hard coded within the provided custom
CC variable which results in a failure when using slibtool instead of
GNU libtool where the two different libtool implementations are
incompatible when both are used during the same build process at once.

This can be solved by using the default value for CC instead where
autotools is capable of providing an adequate value by default. I
attached a patch doing this.

A bug report was issued here:
https://sourceware.org/bugzilla/show_bug.cgi?id=30295

Please see comment 3 with the explanation where before I was missing
the real issue.

[-- Attachment #2: gdb_acinclude_m4.patch --]
[-- Type: text/x-patch, Size: 855 bytes --]

commit 31245fcf4fc31e732f05205f739317e9c8922da3
Author: orbea <orbea@riseup.net>
Date:   Fri Mar 31 09:46:51 2023 -0700

    gdb: Don't overwrite CC when checking for BFD support
    
    When building with an alternative libtool implementation such as
    slibtool the configure check for BFD features will fail in
    gdb/configure.ac because './libtool' was hardcoded.
    
    Simply removing the line allows the configure check to work correctly.

diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4
index 173e40b440..5f7589f9f6 100644
--- a/gdb/acinclude.m4
+++ b/gdb/acinclude.m4
@@ -237,7 +237,6 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [
   LDFLAGS="-L../bfd -L../libiberty $LDFLAGS"
   intl=`echo $LIBINTL | sed 's,${top_builddir}/,,g'`
   LIBS="-lbfd -liberty $intl $LIBS"
-  CC="./libtool --quiet --mode=link $CC"
   AC_CACHE_CHECK(
     [$1],
     [$2],