From: Kevin Buettner <kevinb@redhat.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Do not change type in get_discrete_low_bound
Date: Fri, 28 Apr 2023 09:07:39 -0700 [thread overview]
Message-ID: <20230428090739.4928deb1@f37-zws-nv> (raw)
In-Reply-To: <20230427193515.1060101-1-tromey@adacore.com>
On Thu, 27 Apr 2023 13:35:15 -0600
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> wrote:
> get_discrete_low_bound has this code:
>
> /* Set unsigned indicator if warranted. */
> if (low >= 0)
> type->set_is_unsigned (true);
>
> It's bad to modify a type in a getter like this, so this patch removes
> this code. FWIW I looked and this code has been there since at least
> 1999 (it was in the initial sourceware import).
LGTM.
Reviewed-by: Kevin Buettner <kevinb@redhat.com>
prev parent reply other threads:[~2023-04-28 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 19:35 Tom Tromey
2023-04-28 16:07 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428090739.4928deb1@f37-zws-nv \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).