Re: [PATCH] Pass const frame_info_ptr reference for skip_[language_]trampoline

[Mark Wielaard <mark@klomp.org>]

Hi Tom,

On Wed, May 03, 2023 at 08:07:50PM +0200, Tom de Vries wrote:
> I've submitted a patch at
> https://sourceware.org/pipermail/gdb-patches/2023-May/199342.html .

Thanks for figuring out why the compiler couldn't see through the
destructor. I must admit I didn't really understood that part.

> Indeed it's not a "fix" for the warning as such.
> 
> It's more a follow-up on the observation that the code that triggers
> the warning was introduced for a reason that's no longer valid, so
> we can just remove it and simplify the code, which then also "fixes"
> the warning.

It is an interesting warning because it caused a bit of code
cleanup. But it seems to warn about something, the correct lifetime of
an object, that the compiler doesn't seem able to proof consistently.

Hopefully your simplification of the destructor will make the compile
able to "proof" the correct lifetime and fix the remaining sparc
issue.

Cheers,

Mark