From: Tom Tromey <tom@tromey.com>
To: Mark Wielaard <mark@klomp.org>
Cc: gdb-patches@sourceware.org, Tom Tromey <tom@tromey.com>
Subject: Re: [PATCH] Pass const frame_info_ptr reference for skip_[language_]trampoline
Date: Wed, 03 May 2023 08:50:07 -0600 [thread overview]
Message-ID: <87wn1ptqow.fsf@tromey.com> (raw)
In-Reply-To: <20230502183444.1445634-1-mark@klomp.org> (Mark Wielaard's message of "Tue, 2 May 2023 20:34:44 +0200")
>>>>> "Mark" == Mark Wielaard <mark@klomp.org> writes:
Mark> It isn't clear why only in this one place g++ sees the issue (probably
Mark> because it can inlined enough code in this specific case).
s/inlined/inline/
Could you add a "Bug:" trailer with a link to the bugzilla entry?
Anyway, other than that nit, this looks ok to me. It's a little
unfortunate we don't know why exactly this particular spot warns, but on
the other hand, the fix is harmless (actually an improvement) and we've
worked around plenty of compiler oddities before.
Reviewed-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-05-03 14:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 18:34 Mark Wielaard
2023-05-03 0:33 ` Kevin Buettner
2023-05-03 14:50 ` Tom Tromey [this message]
2023-05-03 15:11 ` Mark Wielaard
2023-05-03 18:07 ` Tom de Vries
2023-05-03 19:18 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn1ptqow.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).