* [PATCH] Remove some FIXME comments from DAP
@ 2023-05-19 15:26 Tom Tromey
2023-05-19 21:11 ` Kevin Buettner
0 siblings, 1 reply; 2+ messages in thread
From: Tom Tromey @ 2023-05-19 15:26 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
I recently added a 'dap' component to bugzilla, and I filed a few bugs
there. This patch removes the corresponding FIXME comments.
A few such comments still exist. In at least one case, I have a fix
I'll be submitting eventually; in others I think I need to do a bit of
investigation to properly file a bug report.
---
gdb/python/lib/gdb/dap/bt.py | 1 -
gdb/python/lib/gdb/dap/evaluate.py | 2 --
gdb/python/lib/gdb/dap/events.py | 3 ---
gdb/python/lib/gdb/dap/next.py | 1 -
4 files changed, 7 deletions(-)
diff --git a/gdb/python/lib/gdb/dap/bt.py b/gdb/python/lib/gdb/dap/bt.py
index c5ede6e4c56..21cedb73d26 100644
--- a/gdb/python/lib/gdb/dap/bt.py
+++ b/gdb/python/lib/gdb/dap/bt.py
@@ -46,7 +46,6 @@ def _backtrace(thread_id, levels, startFrame):
set_thread(thread_id)
frames = []
current_number = 0
- # FIXME could invoke frame filters here.
try:
current_frame = gdb.newest_frame()
except gdb.error:
diff --git a/gdb/python/lib/gdb/dap/evaluate.py b/gdb/python/lib/gdb/dap/evaluate.py
index 55d41b0806d..05816474688 100644
--- a/gdb/python/lib/gdb/dap/evaluate.py
+++ b/gdb/python/lib/gdb/dap/evaluate.py
@@ -51,7 +51,6 @@ def _repl(command, frame_id):
}
-# FIXME 'format' & hex
# FIXME supportsVariableType handling
@request("evaluate")
def eval_request(*, expression, frameId=None, context="variables", **args):
@@ -74,7 +73,6 @@ def _variables(ref, start, count):
@request("variables")
# Note that we ignore the 'filter' field. That seems to be
# specific to javascript.
-# FIXME: implement format
def variables(*, variablesReference, start=0, count=0, **args):
result = send_gdb_with_response(
lambda: _variables(variablesReference, start, count)
diff --git a/gdb/python/lib/gdb/dap/events.py b/gdb/python/lib/gdb/dap/events.py
index 5b25470211f..d9ae603dfa4 100644
--- a/gdb/python/lib/gdb/dap/events.py
+++ b/gdb/python/lib/gdb/dap/events.py
@@ -140,13 +140,10 @@ def _on_stop(event):
global _expected_stop
obj = {
"threadId": gdb.selected_thread().global_num,
- # FIXME we don't support non-stop for now.
"allThreadsStopped": True,
}
if isinstance(event, gdb.BreakpointEvent):
# Ignore the expected stop, we hit a breakpoint instead.
- # FIXME differentiate between 'breakpoint', 'function breakpoint',
- # 'data breakpoint' and 'instruction breakpoint' here.
_expected_stop = StopKinds.BREAKPOINT
obj["hitBreakpointIds"] = [x.number for x in event.breakpoints]
elif _expected_stop is None:
diff --git a/gdb/python/lib/gdb/dap/next.py b/gdb/python/lib/gdb/dap/next.py
index 33898ed6103..636dfce997d 100644
--- a/gdb/python/lib/gdb/dap/next.py
+++ b/gdb/python/lib/gdb/dap/next.py
@@ -47,5 +47,4 @@ def stepIn(*, threadId, granularity="statement", **args):
@request("continue")
def continue_request(**args):
send_gdb(ExecutionInvoker("continue", None))
- # FIXME Just ignore threadId for the time being, and assume all-stop.
return {"allThreadsContinued": True}
--
2.40.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove some FIXME comments from DAP
2023-05-19 15:26 [PATCH] Remove some FIXME comments from DAP Tom Tromey
@ 2023-05-19 21:11 ` Kevin Buettner
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Buettner @ 2023-05-19 21:11 UTC (permalink / raw)
To: Tom Tromey via Gdb-patches; +Cc: Tom Tromey
On Fri, 19 May 2023 09:26:27 -0600
Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> wrote:
> I recently added a 'dap' component to bugzilla, and I filed a few bugs
> there. This patch removes the corresponding FIXME comments.
>
> A few such comments still exist. In at least one case, I have a fix
> I'll be submitting eventually; in others I think I need to do a bit of
> investigation to properly file a bug report.
LGTM.
(And, thanks for adding the 'dap' component.)
Kevin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-19 21:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-19 15:26 [PATCH] Remove some FIXME comments from DAP Tom Tromey
2023-05-19 21:11 ` Kevin Buettner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).