From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org
Subject: [PATCH 3/4] Add a have_native_target helper function for use with require.
Date: Fri, 26 May 2023 10:57:41 -0700 [thread overview]
Message-ID: <20230526175742.66885-4-jhb@FreeBSD.org> (raw)
In-Reply-To: <20230526175742.66885-1-jhb@FreeBSD.org>
Move logic from auto-connect-native-target.exp into this helper.
---
.../gdb.base/auto-connect-native-target.exp | 18 +-----------------
gdb/testsuite/lib/gdb.exp | 17 +++++++++++++++++
2 files changed, 18 insertions(+), 17 deletions(-)
diff --git a/gdb/testsuite/gdb.base/auto-connect-native-target.exp b/gdb/testsuite/gdb.base/auto-connect-native-target.exp
index 002a6d61126..0586cd4baf4 100644
--- a/gdb/testsuite/gdb.base/auto-connect-native-target.exp
+++ b/gdb/testsuite/gdb.base/auto-connect-native-target.exp
@@ -22,23 +22,7 @@ if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} {
return -1
}
-# Whether this GDB is configured with a "native" target.
-set have_native 0
-
-set test "help target native"
-gdb_test_multiple $test $test {
- -re "Undefined target command.*$gdb_prompt $" {
- set have_native 0
- }
- -re "Native process.*$gdb_prompt $" {
- set have_native 1
- }
-}
-
-if { !$have_native } {
- unsupported "no \"target native\" support."
- return
-}
+require have_native_target
# Returns the topmost target pushed on the target stack. TEST is used
# as test message.
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 133d914aff8..128c0779b69 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -9739,6 +9739,23 @@ gdb_caching_proc have_compile_and_link_flag { flag } {
additional_flags=$flag]
}
+# Return 1 if this GDB is configured with a "native" target.
+
+gdb_caching_proc have_native_target {} {
+ global gdb_prompt
+
+ set test "help target native"
+ gdb_test_multiple $test $test {
+ -re "Undefined target command.*$gdb_prompt $" {
+ return 0
+ }
+ -re "Native process.*$gdb_prompt $" {
+ return 1
+ }
+ }
+ return 0
+}
+
# Handle include file $srcdir/$subdir/FILE.
proc include_file { file } {
--
2.40.0
next prev parent reply other threads:[~2023-05-26 17:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 17:57 [PATCH 0/4] Handle null inferiors in target::read_description John Baldwin
2023-05-26 17:57 ` [PATCH 1/4] *-fbsd-nat: Handle null inferior in read_description John Baldwin
2023-07-06 16:18 ` Simon Marchi
2023-07-06 16:56 ` John Baldwin
2023-05-26 17:57 ` [PATCH 2/4] *-linux-nat: " John Baldwin
2023-06-12 8:56 ` Luis Machado
2023-06-12 17:43 ` John Baldwin
2023-05-26 17:57 ` John Baldwin [this message]
2023-07-06 16:24 ` [PATCH 3/4] Add a have_native_target helper function for use with require Simon Marchi
2023-07-06 17:18 ` John Baldwin
2023-05-26 17:57 ` [PATCH 4/4] Test that native targets can read a tdesc without a process attached John Baldwin
2023-06-09 16:55 ` [PING] [PATCH 0/4] Handle null inferiors in target::read_description John Baldwin
2023-06-30 14:22 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526175742.66885-4-jhb@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).