Re: [PATCH 3/4] Add a have_native_target helper function for use with require.

[Simon Marchi <simark@simark.ca>]

> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 133d914aff8..128c0779b69 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -9739,6 +9739,23 @@ gdb_caching_proc have_compile_and_link_flag { flag } {
>  		additional_flags=$flag]
>  }
>  
> +# Return 1 if this GDB is configured with a "native" target.
> +
> +gdb_caching_proc have_native_target {} {
> +    global gdb_prompt
> +
> +    set test "help target native"
> +    gdb_test_multiple $test $test {
> +	-re "Undefined target command.*$gdb_prompt $" {
> +	    return 0
> +	}
> +	-re "Native process.*$gdb_prompt $" {
> +	    return 1
> +	}
> +    }
> +    return 0
> +}
Touching this code would be an opportunity to modernize it.  I think
that if you do:

  gdb_test_multiple "help target native"  "" {

the command is automatically used as the test name (so, no need for the
test variable).

Then, instead of having "$gdb_prompt $", you can probably use -wrap:

  -re -wrap "Undefined target command.*"

  -re -wrap "Native process.*"

Simon