* [PATCH] [AArch64] Fix architecture debug version constant thinkos
@ 2023-06-02 5:43 Luis Machado
2023-06-07 8:46 ` Andrew Burgess
0 siblings, 1 reply; 3+ messages in thread
From: Luis Machado @ 2023-06-02 5:43 UTC (permalink / raw)
To: gdb-patches
Caught this during emulator testing.
Fix the constants. They should be 0xa and 0xb as opposed to 0x10 and
0x11. There was a thinko while defining them.
Obvious enough.
Tested on aarch64-linux Ubuntu 20.04/22.04.
---
gdb/nat/aarch64-hw-point.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/nat/aarch64-hw-point.h b/gdb/nat/aarch64-hw-point.h
index c19681422da..2ff9ccb5c1c 100644
--- a/gdb/nat/aarch64-hw-point.h
+++ b/gdb/nat/aarch64-hw-point.h
@@ -58,9 +58,9 @@
#define AARCH64_DEBUG_ARCH_V8_1 0x7
#define AARCH64_DEBUG_ARCH_V8_2 0x8
#define AARCH64_DEBUG_ARCH_V8_4 0x9
-#define AARCH64_DEBUG_ARCH_V8_8 0x10
+#define AARCH64_DEBUG_ARCH_V8_8 0xa
/* Armv8.9 debug architecture. */
-#define AARCH64_DEBUG_ARCH_V8_9 0x11
+#define AARCH64_DEBUG_ARCH_V8_9 0xb
/* ptrace expects control registers to be formatted as follows:
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [AArch64] Fix architecture debug version constant thinkos
2023-06-02 5:43 [PATCH] [AArch64] Fix architecture debug version constant thinkos Luis Machado
@ 2023-06-07 8:46 ` Andrew Burgess
2023-06-07 8:48 ` Luis Machado
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Burgess @ 2023-06-07 8:46 UTC (permalink / raw)
To: Luis Machado, gdb-patches
Luis Machado via Gdb-patches <gdb-patches@sourceware.org> writes:
> Caught this during emulator testing.
>
> Fix the constants. They should be 0xa and 0xb as opposed to 0x10 and
> 0x11. There was a thinko while defining them.
>
> Obvious enough.
I agree.
Approved-By: Andrew Burgess <aburgess@redhat.com>
Thanks,
Andrew
>
> Tested on aarch64-linux Ubuntu 20.04/22.04.
> ---
> gdb/nat/aarch64-hw-point.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/nat/aarch64-hw-point.h b/gdb/nat/aarch64-hw-point.h
> index c19681422da..2ff9ccb5c1c 100644
> --- a/gdb/nat/aarch64-hw-point.h
> +++ b/gdb/nat/aarch64-hw-point.h
> @@ -58,9 +58,9 @@
> #define AARCH64_DEBUG_ARCH_V8_1 0x7
> #define AARCH64_DEBUG_ARCH_V8_2 0x8
> #define AARCH64_DEBUG_ARCH_V8_4 0x9
> -#define AARCH64_DEBUG_ARCH_V8_8 0x10
> +#define AARCH64_DEBUG_ARCH_V8_8 0xa
> /* Armv8.9 debug architecture. */
> -#define AARCH64_DEBUG_ARCH_V8_9 0x11
> +#define AARCH64_DEBUG_ARCH_V8_9 0xb
>
> /* ptrace expects control registers to be formatted as follows:
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [AArch64] Fix architecture debug version constant thinkos
2023-06-07 8:46 ` Andrew Burgess
@ 2023-06-07 8:48 ` Luis Machado
0 siblings, 0 replies; 3+ messages in thread
From: Luis Machado @ 2023-06-07 8:48 UTC (permalink / raw)
To: Andrew Burgess, gdb-patches
On 6/7/23 09:46, Andrew Burgess wrote:
> Luis Machado via Gdb-patches <gdb-patches@sourceware.org> writes:
>
>> Caught this during emulator testing.
>>
>> Fix the constants. They should be 0xa and 0xb as opposed to 0x10 and
>> 0x11. There was a thinko while defining them.
>>
>> Obvious enough.
>
> I agree.
>
> Approved-By: Andrew Burgess <aburgess@redhat.com>
>
> Thanks,
> Andrew
>
>
Thanks. I should've said I pushed this right after posting. Sorry about that.
>>
>> Tested on aarch64-linux Ubuntu 20.04/22.04.
>> ---
>> gdb/nat/aarch64-hw-point.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gdb/nat/aarch64-hw-point.h b/gdb/nat/aarch64-hw-point.h
>> index c19681422da..2ff9ccb5c1c 100644
>> --- a/gdb/nat/aarch64-hw-point.h
>> +++ b/gdb/nat/aarch64-hw-point.h
>> @@ -58,9 +58,9 @@
>> #define AARCH64_DEBUG_ARCH_V8_1 0x7
>> #define AARCH64_DEBUG_ARCH_V8_2 0x8
>> #define AARCH64_DEBUG_ARCH_V8_4 0x9
>> -#define AARCH64_DEBUG_ARCH_V8_8 0x10
>> +#define AARCH64_DEBUG_ARCH_V8_8 0xa
>> /* Armv8.9 debug architecture. */
>> -#define AARCH64_DEBUG_ARCH_V8_9 0x11
>> +#define AARCH64_DEBUG_ARCH_V8_9 0xb
>>
>> /* ptrace expects control registers to be formatted as follows:
>>
>> --
>> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-07 8:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-02 5:43 [PATCH] [AArch64] Fix architecture debug version constant thinkos Luis Machado
2023-06-07 8:46 ` Andrew Burgess
2023-06-07 8:48 ` Luis Machado
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).