public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Bruno Larsen <blarsen@redhat.com>
To: gdb-patches@sourceware.org
Cc: pedro@palves.net, aburgess@redhat.com, kevinb@redhat.com,
	brobecker@adacore.com, simon.marchi@polymtl.ca, tom@tromey.com,
	tdevries@suse.de, ulrich.weigand@de.ibm.com, eliz@gnu.org,
	Bruno Larsen <blarsen@redhat.com>
Subject: [PATCH v2 0/1] update MAINTAINERS file with git trailers
Date: Mon, 12 Jun 2023 12:01:38 +0200	[thread overview]
Message-ID: <20230612100138.912813-1-blarsen@redhat.com> (raw)

Some private chats highlighted that the currently in use git trailers
aren't explained well enough. This patch aims to fix that by adding the
information in a more verbose way to guarantee that everyone is on the
same page about them and refine anything that might still need work.

The first version of this update didn't get much traction, so I decided
to add every active global maintainer as CC, since everyone is affected
by this and I want some consensus before comitting.

Right now there is one big unanswered question: Should we have a
specific tag to explicitly signal when a patch has been partially
approved? Eli asked for it to avoid people mechanically reading tags
from thinking that a patch has been fully approved when it was only
partial. If we agree that there should be one, what would it look like?
I suggested using Acked-By, but Simon uses it differently, and I opted
to keep his usage of it.

There is a secondary question for me, which is to add a hard requirement
for approval tags. If we add it, the sourceware repository could have a
pre-receive hook (or update hook) that automatically reject pushes if
they dont have an approval tag. This would be especially useful to
avoid accidentally pushing the wrong commit, but is more annoying for
global maintainers (need to approve their own patches) and we'd need to
see what to do about the obvious fix rule. My first answer for that is
adding a special "Approved-By: Obvious fix" or similar.

Thoughts? Comments? Suggestions?

Version 1: https://inbox.sourceware.org/gdb-patches/20230516143826.3431583-1-blarsen@redhat.com/

Bruno Larsen (1):
  [gdb]: add git trailer information on gdb/MAINTAINERS

 gdb/MAINTAINERS | 56 ++++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 48 insertions(+), 8 deletions(-)

-- 
2.40.1


             reply	other threads:[~2023-06-12 10:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-12 10:01 Bruno Larsen [this message]
2023-06-12 10:01 ` [PATCH v2 1/1] [gdb]: add git trailer information on gdb/MAINTAINERS Bruno Larsen
2023-06-12 23:59   ` Kevin Buettner
2023-06-13  7:43     ` Bruno Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230612100138.912813-1-blarsen@redhat.com \
    --to=blarsen@redhat.com \
    --cc=aburgess@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    --cc=pedro@palves.net \
    --cc=simon.marchi@polymtl.ca \
    --cc=tdevries@suse.de \
    --cc=tom@tromey.com \
    --cc=ulrich.weigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).