* [pushed] Simplify case DW_OP_GNU_uninit in dwarf_expr_context::execute_stack_op
@ 2023-06-12 23:04 Kevin Buettner
0 siblings, 0 replies; only message in thread
From: Kevin Buettner @ 2023-06-12 23:04 UTC (permalink / raw)
To: gdb-patches; +Cc: Kevin Buettner
Tom Tromey pointed out that the test and call to error() for the
DW_OP_GNU_uninit case in dwarf_expr_context::execute_stack_op (in
gdb/dwarf2/expr.c)...
if (op_ptr != op_end && *op_ptr != DW_OP_piece
&& *op_ptr != DW_OP_bit_piece)
error (_("DWARF-2 expression error: DW_OP_GNU_uninit must always "
"be the very last op in a DWARF expression or "
"DW_OP_piece/DW_OP_bit_piece piece."));
...could be replaced by a call to dwarf_expr_require_composition which
performs a similar check and outputs a suitable error message.
---
gdb/dwarf2/expr.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/gdb/dwarf2/expr.c b/gdb/dwarf2/expr.c
index 7e1666165d7..b21016eb38b 100644
--- a/gdb/dwarf2/expr.c
+++ b/gdb/dwarf2/expr.c
@@ -2200,12 +2200,7 @@ dwarf_expr_context::execute_stack_op (const gdb_byte *op_ptr,
goto no_push;
case DW_OP_GNU_uninit:
- if (op_ptr != op_end && *op_ptr != DW_OP_piece
- && *op_ptr != DW_OP_bit_piece)
- error (_("DWARF-2 expression error: DW_OP_GNU_uninit must always "
- "be the very last op in a DWARF expression or "
- "DW_OP_piece/DW_OP_bit_piece piece."));
-
+ dwarf_expr_require_composition (op_ptr, op_end, "DW_OP_GNU_uninit");
this->m_initialized = false;
goto no_push;
--
2.40.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-06-12 23:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-12 23:04 [pushed] Simplify case DW_OP_GNU_uninit in dwarf_expr_context::execute_stack_op Kevin Buettner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).