From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH v2 7/8] Remove aop_last
Date: Tue, 20 Jun 2023 11:36:43 -0600 [thread overview]
Message-ID: <20230619-ax-new-v2-7-47638d750dd7@tromey.com> (raw)
In-Reply-To: <20230619-ax-new-v2-0-47638d750dd7@tromey.com>
aop_last is only used for an assertion. However, due to the '.def'
construct in the sources, this assert could never plausibly trigger
(the assert predates the use of a .def file here). This patch removes
the constant and the assert.
---
gdb/ax-general.c | 6 ------
gdb/ax.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/gdb/ax-general.c b/gdb/ax-general.c
index a8451d71b2e..4ace2b490c0 100644
--- a/gdb/ax-general.c
+++ b/gdb/ax-general.c
@@ -349,12 +349,6 @@ ax_print (struct ui_file *f, struct agent_expr *x)
}
gdb_printf (f, _("\n"));
- /* Check the size of the name array against the number of entries in
- the enum, to catch additions that people didn't sync. */
- if ((sizeof (aop_map) / sizeof (aop_map[0]))
- != aop_last)
- error (_("GDB bug: ax-general.c (ax_print): opcode map out of sync"));
-
for (i = 0; i < x->buf.size ();)
{
enum agent_op op = (enum agent_op) x->buf[i];
diff --git a/gdb/ax.h b/gdb/ax.h
index 1fdecb2f9e5..e02aa7104ea 100644
--- a/gdb/ax.h
+++ b/gdb/ax.h
@@ -154,7 +154,6 @@ enum agent_op
aop_ ## NAME = VALUE,
#include "gdbsupport/ax.def"
#undef DEFOP
- aop_last
};
\f
--
2.39.2
next prev parent reply other threads:[~2023-06-20 17:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 17:36 [PATCH v2 0/8] C++-ify and simplify agent expressions Tom Tromey
2023-06-20 17:36 ` [PATCH v2 1/8] Remove mem2hex Tom Tromey
2023-06-20 17:36 ` [PATCH v2 2/8] Use gdb::byte_vector in agent_expr Tom Tromey
2023-06-24 1:40 ` Simon Marchi
2023-06-30 3:16 ` Tom Tromey
2023-06-20 17:36 ` [PATCH v2 3/8] Use std::vector<bool> for agent_expr::reg_mask Tom Tromey
2023-06-21 16:16 ` Simon Marchi
2023-06-23 2:37 ` Tom Tromey
2023-06-20 17:36 ` [PATCH v2 4/8] Simplify agent_expr constructor Tom Tromey
2023-06-20 17:36 ` [PATCH v2 5/8] Use bool for agent_expr::tracing Tom Tromey
2023-06-20 17:36 ` [PATCH v2 6/8] Make aop_map 'static' Tom Tromey
2023-06-20 17:36 ` Tom Tromey [this message]
2023-06-20 17:36 ` [PATCH v2 8/8] Use ARRAY_SIZE in ax-general.c Tom Tromey
2023-06-20 17:45 ` [PATCH v2 0/8] C++-ify and simplify agent expressions John Baldwin
2023-06-20 18:01 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230619-ax-new-v2-7-47638d750dd7@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).