From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 8/8] Change 'handle_id' to be a local variable
Date: Sun, 09 Jul 2023 11:01:54 -0600 [thread overview]
Message-ID: <20230709-trace-cleanups-v1-8-c410e1072fab@tromey.com> (raw)
In-Reply-To: <20230709-trace-cleanups-v1-0-c410e1072fab@tromey.com>
The global variable 'handle_id' in tracectf.c is only used in a single
function, so change it to be a local variable.
---
gdb/tracectf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/gdb/tracectf.c b/gdb/tracectf.c
index c2b55426b41..0ed2092c32b 100644
--- a/gdb/tracectf.c
+++ b/gdb/tracectf.c
@@ -855,7 +855,6 @@ class ctf_target final : public tracefile_target
};
/* The struct pointer for current CTF directory. */
-static int handle_id = -1;
static struct bt_context *ctx = NULL;
static struct bt_ctf_iter *ctf_iter = NULL;
/* The position of the first packet containing trace frame. */
@@ -895,7 +894,7 @@ ctf_open_dir (const char *dirname)
ctx = bt_context_create ();
if (ctx == NULL)
error (_("Unable to create bt_context"));
- handle_id = bt_context_add_trace (ctx, dirname, "ctf", NULL, NULL, NULL);
+ int handle_id = bt_context_add_trace (ctx, dirname, "ctf", NULL, NULL, NULL);
if (handle_id < 0)
{
ctf_destroy ();
--
2.41.0
next prev parent reply other threads:[~2023-07-09 17:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 17:01 [PATCH 0/8] Minor C++-ification and cleanup in trace targets Tom Tromey
2023-07-09 17:01 ` [PATCH 1/8] Remove a use of xfree Tom Tromey
2023-07-09 17:01 ` [PATCH 2/8] Replace use of xfree with byte_vector Tom Tromey
2023-07-09 17:01 ` [PATCH 3/8] Use unique_ptr for trace_filename Tom Tromey
2023-07-09 17:01 ` [PATCH 4/8] Use unique_ptr for trace_dirname Tom Tromey
2023-07-09 17:01 ` [PATCH 5/8] Use function_view in traceframe_walk_blocks Tom Tromey
2023-07-09 17:01 ` [PATCH 6/8] Constify tfile_interp_line Tom Tromey
2023-07-09 17:01 ` [PATCH 7/8] Move definition of ctf_target type Tom Tromey
2023-07-09 17:01 ` Tom Tromey [this message]
2023-07-09 20:52 ` [PATCH 0/8] Minor C++-ification and cleanup in trace targets Keith Seitz
2023-07-10 19:02 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230709-trace-cleanups-v1-8-c410e1072fab@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).