From: Tom Tromey <tom@tromey.com>
To: Keith Seitz via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>, Keith Seitz <keiths@redhat.com>
Subject: Re: [PATCH 0/8] Minor C++-ification and cleanup in trace targets
Date: Mon, 10 Jul 2023 13:02:56 -0600 [thread overview]
Message-ID: <87mt03r3mn.fsf@tromey.com> (raw)
In-Reply-To: <13d19c12-3570-ad65-e676-619fb474b386@redhat.com> (Keith Seitz via Gdb-patches's message of "Sun, 9 Jul 2023 13:52:41 -0700")
> I've read through the series, and I don't see anything concerning here.
> Only ~340 more uses of xfree left. :-)
> Reviewed-by: Keith Seitz <keiths@redhat.com>
Thanks, I'm going to check it in.
Tom
prev parent reply other threads:[~2023-07-10 19:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 17:01 Tom Tromey
2023-07-09 17:01 ` [PATCH 1/8] Remove a use of xfree Tom Tromey
2023-07-09 17:01 ` [PATCH 2/8] Replace use of xfree with byte_vector Tom Tromey
2023-07-09 17:01 ` [PATCH 3/8] Use unique_ptr for trace_filename Tom Tromey
2023-07-09 17:01 ` [PATCH 4/8] Use unique_ptr for trace_dirname Tom Tromey
2023-07-09 17:01 ` [PATCH 5/8] Use function_view in traceframe_walk_blocks Tom Tromey
2023-07-09 17:01 ` [PATCH 6/8] Constify tfile_interp_line Tom Tromey
2023-07-09 17:01 ` [PATCH 7/8] Move definition of ctf_target type Tom Tromey
2023-07-09 17:01 ` [PATCH 8/8] Change 'handle_id' to be a local variable Tom Tromey
2023-07-09 20:52 ` [PATCH 0/8] Minor C++-ification and cleanup in trace targets Keith Seitz
2023-07-10 19:02 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt03r3mn.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=keiths@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).