* [pushed] Report supportsBreakpointLocationsRequest
@ 2023-07-27 16:35 Tom Tromey
0 siblings, 0 replies; only message in thread
From: Tom Tromey @ 2023-07-27 16:35 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
While looking at the DAP spec, I noticed that the breakpointLocations
request is gated behind a capability. This patch changes gdb to
report this capability.
I've also added a comment to explain the fact that arguments to
breakpointLocations are not optional, even though the spec says they
are.
---
gdb/python/lib/gdb/dap/locations.py | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/gdb/python/lib/gdb/dap/locations.py b/gdb/python/lib/gdb/dap/locations.py
index 6c591579920..594f1bad45b 100644
--- a/gdb/python/lib/gdb/dap/locations.py
+++ b/gdb/python/lib/gdb/dap/locations.py
@@ -18,7 +18,7 @@ import gdb
# This is deprecated in 3.9, but required in older versions.
from typing import Optional
-from .server import request
+from .server import capability, request
from .startup import in_gdb_thread, send_gdb_with_response
@@ -32,7 +32,15 @@ def _find_lines(filename, start_line, end_line):
return {"breakpoints": [{"line": x} for x in sorted(lines)]}
+# Note that the spec says that the arguments to this are optional.
+# However, calling this without arguments is nonsensical. This is
+# discussed in:
+# https://github.com/microsoft/debug-adapter-protocol/issues/266
+# This points out that fixing this would be an incompatibility but
+# goes on to propose "if arguments property is missing, debug adapters
+# should return an error".
@request("breakpointLocations")
+@capability("supportsBreakpointLocationsRequest")
def breakpoint_locations(*, source, line: int, endLine: Optional[int] = None, **extra):
if endLine is None:
endLine = line
--
2.40.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-07-27 16:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-27 16:35 [pushed] Report supportsBreakpointLocationsRequest Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).