From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH v2 6/6] [gdb/testsuite] Extend gdb.base/index-cache.exp
Date: Wed, 2 Aug 2023 11:53:05 +0200 [thread overview]
Message-ID: <20230802095305.3668-7-tdevries@suse.de> (raw)
In-Reply-To: <20230802095305.3668-1-tdevries@suse.de>
The test-case gdb.base/index-cache.exp uses only one source file, which
contains main.
While doing "file $exec", in set_initial_language a symbol lookup of "main" is
done, causing the symtab containing main to be expanded.
Handling of main is special, and a future optimization may skip the lookup and
expansion.
Reliably exercise:
- the lookup of main, expanding the symtab containing main, by doing
"ptype main", and
- the lookup of another symbol, expanding a symtab not containing main, by:
- adding another source file containing function foo, and
- doing "ptype foo".
This triggered a segfault with target board native-extended-gdbserver, filed
as PR symtab/30712, but that seems to be fixed by a previous commit in this
series.
Tested on x86_64-linux.
---
gdb/testsuite/gdb.base/index-cache-2.c | 24 ++++++++++++++++++++++++
gdb/testsuite/gdb.base/index-cache.c | 6 ++++--
gdb/testsuite/gdb.base/index-cache.exp | 22 ++++++++++++++++++++--
3 files changed, 48 insertions(+), 4 deletions(-)
create mode 100644 gdb/testsuite/gdb.base/index-cache-2.c
diff --git a/gdb/testsuite/gdb.base/index-cache-2.c b/gdb/testsuite/gdb.base/index-cache-2.c
new file mode 100644
index 00000000000..d0c10780499
--- /dev/null
+++ b/gdb/testsuite/gdb.base/index-cache-2.c
@@ -0,0 +1,24 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2023 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+extern int foo (void);
+
+int
+foo (void)
+{
+ return 0;
+}
diff --git a/gdb/testsuite/gdb.base/index-cache.c b/gdb/testsuite/gdb.base/index-cache.c
index 16521df96f5..fecba981b91 100644
--- a/gdb/testsuite/gdb.base/index-cache.c
+++ b/gdb/testsuite/gdb.base/index-cache.c
@@ -15,9 +15,11 @@
You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>. */
+extern int foo (void);
+
int
-main ()
+main (void)
{
- return 0;
+ return foo ();
}
diff --git a/gdb/testsuite/gdb.base/index-cache.exp b/gdb/testsuite/gdb.base/index-cache.exp
index 9f2f53053cb..c26c4f94e65 100644
--- a/gdb/testsuite/gdb.base/index-cache.exp
+++ b/gdb/testsuite/gdb.base/index-cache.exp
@@ -16,9 +16,9 @@
# This test checks that the index-cache feature generates the expected files at
# the expected location.
-standard_testfile
+standard_testfile .c -2.c
-if { [build_executable "failed to prepare" $testfile $srcfile \
+if { [build_executable "failed to prepare" $testfile [list $srcfile $srcfile2] \
{debug ldflags=-Wl,--build-id}] } {
return
}
@@ -147,6 +147,12 @@ proc_with_prefix test_cache_disabled { cache_dir test_prefix } {
gdb_assert "$nfiles_created == 0" "no files were created"
check_cache_stats 0 0
+
+ # Trigger expansion of symtab containing main, if not already done.
+ gdb_test "ptype main" "^type = int \\(void\\)"
+
+ # Trigger expansion of symtab not containing main.
+ gdb_test "ptype foo" "^type = int \\(void\\)"
}
}
}
@@ -192,6 +198,12 @@ proc_with_prefix test_cache_enabled_miss { cache_dir } {
} else {
check_cache_stats 0 0
}
+
+ # Trigger expansion of symtab containing main, if not already done.
+ gdb_test "ptype main" "^type = int \\(void\\)"
+
+ # Trigger expansion of symtab not containing main.
+ gdb_test "ptype foo" "^type = int \\(void\\)"
}
}
@@ -221,6 +233,12 @@ proc_with_prefix test_cache_enabled_hit { cache_dir } {
} else {
check_cache_stats 0 0
}
+
+ # Trigger expansion of symtab containing main, if not already done.
+ gdb_test "ptype main" "^type = int \\(void\\)"
+
+ # Trigger expansion of symtab not containing main.
+ gdb_test "ptype foo" "^type = int \\(void\\)"
}
}
--
2.35.3
next prev parent reply other threads:[~2023-08-02 9:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 9:52 [PATCH v2 0/6] [gdb/symtab] Fix data-races in gdb.base/index-cache.exp Tom de Vries
2023-08-02 9:53 ` [PATCH v2 1/6] [gdb/symtab] Fix data race on index_cache::m_enabled Tom de Vries
2023-08-02 19:29 ` Tom Tromey
2023-08-04 0:08 ` Tom de Vries
2023-08-02 9:53 ` [PATCH v2 2/6] [gdb/symtab] Fix data race on bfd::{cacheable,format} Tom de Vries
2023-08-02 19:32 ` Tom Tromey
2023-08-04 0:09 ` Tom de Vries
2023-08-04 15:57 ` Tom Tromey
2023-08-02 9:53 ` [PATCH v2 3/6] [gdb/symtab] Fix race on dwarf2_per_cu_data::{queued,is_debug_type} Tom de Vries
2023-08-02 19:34 ` [PATCH v2 3/6] [gdb/symtab] Fix race on dwarf2_per_cu_data::{queued, is_debug_type} Tom Tromey
2023-08-02 9:53 ` [PATCH v2 4/6] [gdb/symtab] Fix data race on bfd_last_cache Tom de Vries
2023-08-02 19:37 ` Tom Tromey
2023-08-03 14:04 ` Tom de Vries
2023-08-02 9:53 ` [PATCH v2 5/6] [gdb/symtab] Fix data race on dwarf2_per_cu_data::{m_header_read_in,is_debug_type} Tom de Vries
2023-08-02 19:39 ` [PATCH v2 5/6] [gdb/symtab] Fix data race on dwarf2_per_cu_data::{m_header_read_in, is_debug_type} Tom Tromey
2023-08-02 9:53 ` Tom de Vries [this message]
2023-08-02 19:41 ` [PATCH v2 6/6] [gdb/testsuite] Extend gdb.base/index-cache.exp Tom Tromey
2023-08-02 19:44 ` [PATCH v2 0/6] [gdb/symtab] Fix data-races in gdb.base/index-cache.exp Tom Tromey
2023-08-04 0:14 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230802095305.3668-7-tdevries@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).